Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per interface

From: Daniel Borkmann <[email-masked]>
Date: Tue, 12 Jan 2010 01:09:09 +0100

Matt Mackall wrote:
> On Mon, 2010-01-11 at 15:59 -0800, David Miller wrote:
>> From: Matt Mackall <[email-masked]>
>> Date: Mon, 11 Jan 2010 17:21:48 -0600
>>
>>> Looks pretty good. Dave?
>>>
>>> Acked-by: Matt Mackall <[email-masked]>
>> I don't like the loop for RX ARP processing.
>>
>> The packet contents aren't going to change, so doing basic
>> packet validation inside of the "for each RX client" loop
>> of arp_reply() doesn't make any sense.
> 
> True. Dan, please help our poor compilers with some manual loop
> invariant motion.

Okay, true. I'll fix this by tomorrow and resend the patch.

Best regards,
Daniel