Subject: Re: [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4

From: Emese Revfy <[email-masked]>
Date: Sun, 17 Jan 2010 21:15:59 +0100

Al Viro wrote:
> On Sun, Jan 17, 2010 at 06:25:37PM +0000, Al Viro wrote:
>> On Sun, Jan 17, 2010 at 05:20:38PM +0100, Emese Revfy wrote:
>>
>>> Signed-off-by: Emese Revfy <[email-masked]>
>>> Acked-by: David Teigland <[email-masked]>
>>> Acked-by: Matt Domsch <[email-masked]>
>>> Acked-by: Maciej Sosnowski <[email-masked]>
>>> Acked-by: Hans J. Koch <[email-masked]>
>>> Acked-by: Pekka Enberg <[email-masked]>
>>> Acked-by: Jens Axboe <[email-masked]>
>>> Acked-by: Stephen Hemminger <[email-masked]>
>> NACKed-by: Al Viro <[email-masked]>
>>
>> Same reason.
> 
> BTW, commit 9905a43b2d563e6f89e4c63c4278ada03f2ebb14
> Author: Emese Revfy <[email-masked]>
> Date:   Mon Dec 14 00:58:57 2009 +0100
> 
>     backlight: Constify struct backlight_ops
> 
> is also crap; again, same reason.  Would you please get a clue and stop
> pushing that particular bullshit into the tree?

The backlight maintainer accepted that patch before the discussion
on field constification concluded.
I drew his attention to the discussion (http://lkml.org/lkml/2009/12/16/395)
but he still accepted the patch as is.
--
Emese