From: Patrick McHardy <kaber@trash•net>
To: Hagen Paul Pfeifer <hagen@jauu•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH 1/1] sched: add head drop fifo queue
Date: Mon, 18 Jan 2010 17:34:54 +0100 [thread overview]
Message-ID: <4B548DAE.3000205@trash.net> (raw)
In-Reply-To: <1263832258-30297-1-git-send-email-hagen@jauu.net>
Hagen Paul Pfeifer wrote:
> This add an additional queuing strategy, called pfifo_head_drop,
> to remove the oldest skb in the case of an overflow within the queue -
> the head element - instead of the last skb (tail). To remove the oldest
> skb in a congested situations is useful for sensor network environments
> where newer packets reflects the superior information.
>
> Reviewed-by: Florian Westphal <fw@strlen•de>
> Signed-off-by: Hagen Paul Pfeifer <hagen@jauu•net>
This looks better than the last one :)
A last comment below, than you can add my
Acked-by: Patrick McHardy <kaber@trash•net>
> +struct Qdisc_ops pfifo_head_drop_qdisc_ops __read_mostly = {
> + .id = "pfifo_head_drop",
> + .priv_size = sizeof(struct fifo_sched_data),
> + .enqueue = pfifo_front_enqueue,
> + .dequeue = qdisc_dequeue_head,
> + .peek = qdisc_peek_head,
> + .drop = qdisc_queue_drop,
> + .init = fifo_init,
> + .reset = qdisc_reset_queue,
> + .change = fifo_init,
> + .dump = fifo_dump,
> + .owner = THIS_MODULE,
> +};
> +EXPORT_SYMBOL(pfifo_head_drop_qdisc_ops);
The EXPORT_SYMBOL shouldn't be needed as sch_fifo can only be
linked statically and no other modules are using this as default.
next prev parent reply other threads:[~2010-01-18 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 13:21 [PATCH 1/1] sched: add head drop fifo queue Hagen Paul Pfeifer
2010-01-18 14:24 ` Patrick McHardy
2010-01-18 16:27 ` Hagen Paul Pfeifer
2010-01-18 16:32 ` Hagen Paul Pfeifer
2010-01-18 16:30 ` Hagen Paul Pfeifer
2010-01-18 16:34 ` Patrick McHardy [this message]
2010-01-18 16:44 ` Hagen Paul Pfeifer
2010-01-18 19:25 ` Jarek Poplawski
2010-01-18 19:36 ` Hagen Paul Pfeifer
2010-01-18 19:51 ` Jarek Poplawski
2010-01-18 19:59 ` Hagen Paul Pfeifer
2010-01-18 20:27 ` [PATCH V2] " Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B548DAE.3000205@trash.net \
--to=kaber@trash$(echo .)net \
--cc=hagen@jauu$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox