From: Li Yewang <lyw@cn•fujitsu.com>
To: David Miller <davem@davemloft•net>
Cc: herbert@gondor•apana.org.au, netdev@vger•kernel.org
Subject: Re: [PATCH][XFRM] Use the simple name when adding SAD with ip xfrm state
Date: Thu, 21 Jan 2010 13:22:17 +0800 [thread overview]
Message-ID: <4B57E489.6010707@cn.fujitsu.com> (raw)
In-Reply-To: <20100119.003041.193317921.davem@davemloft.net>
Sorry, I am new to crypto.
I searched the soucre code in the directory of /crypto,
and found that, all cryptos use shortname, for example:
crypto/xcbc.c
static struct crypto_template crypto_xcbc_tmpl = {
.name = "xcbc",
.create = xcbc_create,
.free = shash_free_instance,
.module = THIS_MODULE,
};
The name such as rfc3686(ctr(aes)) only used by "ip xfrm state" command to set SAD.
David Miller wrote:
> From: Li Yewang <lyw@cn•fujitsu.com>
> Date: Tue, 19 Jan 2010 16:25:22 +0800
>
>>
>> Herbert Xu wrote:
>>> Li Yewang <lyw@cn•fujitsu.com> wrote:
>>>> The encryption name such as "rfc3686(ctr(aes))" is too complex.
>>>> I think simple name is better for user when using "ip xfrm state ..." command.
>>>>
>>>>
>>>> Signed-off-by: Li Yewang <lyw@cn•fujitsu.com>
>>> Nack. If we want to support simple names such as these, they
>>> should be done in the crypto layer. Otherwise every crypto user
>>> that wants this would have to reinvent it.
>> But user sets SAD for ipsec with "ip xfrm state ..." must use the name such as "rfc3686(ctr(aes))".
>> Is that reasonable? Maybe user can not remember this complex name.
>>
>> There are some simple names for other encryptions,
>> such as "cbc(blowfish)", you can use "ip xfrm state ... enc blowfish ...".
>
> You're not reading what Herbert is saying.
>
> He's fine with the shorter name, he just wants you to implement
> is in the crypto layer core instead of the XFRM specific code.
>
> That way all crypto users will benefit from the shorter naming.
>
>
>
--
Regards
Li Yewang
--------------------------------------------------
Li Yewang
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
8/F., Civil Defense Building, No.189 Guangzhou Road,
Nanjing, 210029, China
TEL: +86+25-86630566-888
COINS: 79955-888
FAX: +86+25-83317685
MAIL: lyw@cn•fujitsu.com
--------------------------------------------------
next prev parent reply other threads:[~2010-01-21 5:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 8:42 [PATCH][XFRM] Use the simple name when adding SAD with ip xfrm state Li Yewang
2010-01-18 8:48 ` Li Yewang
2010-01-19 2:20 ` Herbert Xu
2010-01-19 8:25 ` Li Yewang
2010-01-19 8:30 ` David Miller
2010-01-21 5:22 ` Li Yewang [this message]
2010-01-21 9:10 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B57E489.6010707@cn.fujitsu.com \
--to=lyw@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox