Subject: Re: [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters

From: Taku Izumi <[email-masked]>
Date: Fri, 22 Jan 2010 17:46:30 +0900

(2010/01/22 15:25), Joe Perches wrote:
> Trivial:
> 
> All of the printks without KERN_<level>  should be KERN_CONT
> 
> For example:
> 
>> +	printk(KERN_ERR "%-15s ", rname);
>> +	for (n = 0; n<  2; n++)
>> +		printk("%08x ", __er32(hw, get_regofs(n)));
>> +	printk("\n");
> 
> This should be:
> 
> 	printk(KERN_ERR etc...)
> 	for (n = 0...)
> 		printk(KERN_CONT "%08x ", etc...
> 	printk(KERN_CONT "\n")
> 
> or perhaps written without the for loop
> 
> 	printk(KERN_ERR "%-15s %08x %08x\n",
> 	       name, __er32(hw, get_regofs(0)), __er32(hw, get_regofs(1)));
> 

Thank you for good information! I didn't realize that.
I'll rewrite all.

Best regards,
Taku Izumi