From: Michael <michael@moffatt•org.nz>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: Andrew Morton <akpm@linux-foundation•org>,
netdev@vger•kernel.org, bugzilla-daemon@bugzilla•kernel.org,
bugme-daemon@bugzilla•kernel.org,
Alan Cox <alan@lxorguk•ukuu.org.uk>,
stable@kernel•org, "David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] starfire: Clean up properly if firmware loading fails
Date: Tue, 26 Jan 2010 15:58:39 +1300 [thread overview]
Message-ID: <4B5E5A5F.90608@moffatt.org.nz> (raw)
In-Reply-To: <1264473168.373.354.camel@localhost>
Hi guys,
I think I'm the submitter that Ben is referring to.
So that could be the answer to the kernel BUG I have reported, but I
don't think that it will answer why the interface doesn't come up... or
does it?
Cheers,
Michael.
Ben Hutchings wrote:
> On Mon, 2010-01-25 at 18:15 -0800, Andrew Morton wrote:
>
>> On Tue, 26 Jan 2010 02:02:12 +0000 Ben Hutchings <bhutchings@solarflare•com> wrote:
>>
>>
>>> netdev_open() will return without cleaning up net device or hardware
>>> state if firmware loading fails. This results in a BUG() on a second
>>> attempt to bring the interface up, reported in
>>> <http://bugzilla.kernel.org/show_bug.cgi?id=15117>, and probably has
>>> even worse effects if the driver is removed afterwards.
>>>
>> (That's the wrong bugzilla URL)
>>
>
> Hah, well spotted. Must have copied from the wrong tab.
>
>
>>> Call netdev_close() to clean up on failure.
>>>
>> OK, thanks.
>>
>>
>>> ---
>>> On Mon, 2010-01-25 at 17:08 -0800, Andrew Morton wrote:
>>>
>>>> (switched to email. Please respond via emailed reply-to-all, not via the
>>>> bugzilla web interface).
>>>>
>>>> On Wed, 20 Jan 2010 04:29:20 GMT
>>>> bugzilla-daemon@bugzilla•kernel.org wrote:
>>>>
>>>>
>>>>> http://bugzilla.kernel.org/show_bug.cgi?id=15091
>>>>>
>>>>> Summary: starfire causes kernel BUG when interface goes up
>>>>>
>>> [...]
>>>
>>>>> I formerly used 2.6.20 and 2.6.24 with a couple of starfire 4 port ethernet
>>>>> cards. On 2.6.32 the interfaces don't start on boot and when I issue "ifconfig
>>>>> ethX up" (where X is a starfire port).
>>>>>
>>> [...]
>>>
>>>> Starfire is triggering the BUG_ON(!test_bit(NAPI_STATE_SCHED,
>>>> &n->state)); in napi_enable().
>>>>
>>>> This is a regression somewhere between 2.6.24 and 2.6.32(!).
>>>>
>>> This driver now attempts to load firmware when an interface is brought
>>> up, *after* calling napi_enable(). If that fails, it will return
>>> without calling napi_disable(). On the second attempt to bring the
>>> interface it calls napi_enable() a second time and triggers this
>>> assertion.
>>>
>>> As a workaround, try installing the necessary firmware. :-)
>>>
>>>
>> Missing signed-off-by. I added it, OK? Also added a Cc:stable.
>>
> [...]
>
> Well I was going to wait and see what the submitter says first, but I'm
> happy for you to add that in your patch set if it's a positive result.
>
> Ben.
>
>
next prev parent reply other threads:[~2010-01-26 2:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-15091-10286@http.bugzilla.kernel.org/>
2010-01-26 1:08 ` [Bugme-new] [Bug 15091] New: starfire causes kernel BUG when interface goes up Andrew Morton
2010-01-26 1:44 ` Michael
2010-01-26 1:51 ` Andrew Morton
2010-01-26 2:02 ` [PATCH] starfire: Clean up properly if firmware loading fails Ben Hutchings
2010-01-26 2:15 ` Andrew Morton
2010-01-26 2:32 ` Ben Hutchings
2010-01-26 2:58 ` Michael [this message]
2010-01-26 3:28 ` Andrew Morton
2010-01-26 5:51 ` Michael
2010-01-26 5:57 ` Andrew Morton
2010-01-26 14:40 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5E5A5F.90608@moffatt.org.nz \
--to=michael@moffatt$(echo .)org.nz \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=bhutchings@solarflare$(echo .)com \
--cc=bugme-daemon@bugzilla$(echo .)kernel.org \
--cc=bugzilla-daemon@bugzilla$(echo .)kernel.org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox