Subject: Re: [PATCH] sctp: IPsec rules are ineffective with ipv6

From: Vlad Yasevich <[email-masked]>
Date: Thu, 28 Jan 2010 10:24:18 -0500

David Miller wrote:
> From: Nicolas Dichtel <[email-masked]>
> Date: Wed, 27 Jan 2010 15:12:59 +0100
> 
>> xfrm_lookup() is missing in sctp_v6_xmit(), add it.
>>
>> Signed-off-by: Junwei Zhang <[email-masked]>
>> Signed-off-by: Nicolas Dichtel <[email-masked]>
> 
> Doing this every transmit packet is overkill.
> 
> Whatever calculates the route that ends up in skb_dst(skb)
> should be making this xfrm_lookup() call, not here.
> 

Hmm.. Interesting.  Looks like ip_route_output_key() will
do xfrm_lookup for you, but there is no ipv6 route lookup call
that will do the same thing.

I guess we'll need to add an xfrm_lookup call in sctp_v6_get_dst().

-vlad