From: Vlad Yasevich <vladislav.yasevich@hp•com>
To: nicolas.dichtel@dev•6wind.com
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, linux-sctp@vger•kernel.org
Subject: Re: [PATCH] sctp: IPsec rules are ineffective with ipv6
Date: Thu, 28 Jan 2010 11:36:33 -0500 [thread overview]
Message-ID: <4B61BD11.5020303@hp.com> (raw)
In-Reply-To: <4B61B047.10908@dev.6wind.com>
Nicolas Dichtel wrote:
> What about this one?
>
> Only compilation tested.
>
> xfrm_lookup() is missing in IPv6 output path. Call it when dst is build.
> Initial patch was written by Junwei Zhang <junwei.zhang@6wind•com>
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
Looks like it might do the right thing. Please run your tests
on this an let me.
Thanks
-vlad
>
> Le 28.01.2010 16:24, Vlad Yasevich a écrit :
>>
>> David Miller wrote:
>>> From: Nicolas Dichtel <nicolas.dichtel@dev•6wind.com>
>>> Date: Wed, 27 Jan 2010 15:12:59 +0100
>>>
>>>> xfrm_lookup() is missing in sctp_v6_xmit(), add it.
>>>>
>>>> Signed-off-by: Junwei Zhang <junwei.zhang@6wind•com>
>>>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
>>> Doing this every transmit packet is overkill.
>>>
>>> Whatever calculates the route that ends up in skb_dst(skb)
>>> should be making this xfrm_lookup() call, not here.
>>>
>>
>>
>> Hmm.. Interesting. Looks like ip_route_output_key() will
>> do xfrm_lookup for you, but there is no ipv6 route lookup call
>> that will do the same thing.
>>
>> I guess we'll need to add an xfrm_lookup call in sctp_v6_get_dst().
>>
>> -vlad
next prev parent reply other threads:[~2010-01-28 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 14:12 [PATCH] sctp: IPsec rules are ineffective with ipv6 Nicolas Dichtel
2010-01-28 13:51 ` David Miller
2010-01-28 15:24 ` Vlad Yasevich
2010-01-28 15:41 ` Nicolas Dichtel
2010-01-28 16:36 ` Vlad Yasevich [this message]
2010-01-28 18:25 ` Nicolas Dichtel
2010-01-29 2:03 ` Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B61BD11.5020303@hp.com \
--to=vladislav.yasevich@hp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@dev$(echo .)6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox