Subject: Re: [PATCH net-next-2.6] can: add support for CAN interface cards based on the PLX90xx PCI bridge

From: Wolfgang Grandegger <[email-masked]>
Date: Sat, 30 Jan 2010 20:04:14 +0100

Wolfgang Grandegger wrote:
> Hi Pavel,
> 
> Pavel B. Cheblakov wrote:
>> From: Pavel Cheblakov <[email-masked]>
>>
>> This driver is for CAN interface cards based on the PLX90xx PCI bridge.
>> Driver supports now:
>>  - Adlink PCI-7841/cPCI-7841 card (http://www.adlinktech.com/)
>>  - Adlink PCI-7841/cPCI-7841 SE card
>>  - Marathon CAN-bus-PCI card (http://www.marathon.ru/)
>>  - TEWS TECHNOLOGIES TPMC810 card (http://www.tews.com/)
>>
>> Signed-off-by: Pavel Cheblakov <[email-masked]>
> 
> We already discussed this patch on the Socketcan mailing list and it's
> OK from my point of view. Please fix the minor issues reported by Daniel
> Baluta. To v2 of the patch you can then add directly my
> "Acked-by: Wolfgang Grandegger <[email-masked]>"

I just realized one more issue. The driver creates section mismatches.
Please use "static DEFINE_PCI_DEVICE_TABLE(plx_pci_tbl)" as, for
example, the ems_pci driver does.

Wolfgang.