Subject: Re: [Patch] net: export TCP send buffer size via netlink

From: Cong Wang <[email-masked]>
Date: Mon, 01 Feb 2010 17:04:33 +0800

Eric Dumazet wrote:
> Le lundi 01 février 2010 à 02:59 -0500, Amerigo Wang a écrit :
>> Currently, we can only get TCP send buffer size by
>> getsockopt (SO_SNDBUF or TCP_INFO), this is not enough
>> for the tools like netstat or ss to read.
>>
>> Show TCP send buffer size via netlink NETLINK_INET_DIAG.
>>
>> Signed-off-by: WANG Cong <[email-masked]>
>> Cc: David Miller <[email-masked]>
>>
>> ---
>> diff --git a/include/linux/tcp.h b/include/linux/tcp.h
>> index 7fee8a4..46768de 100644
>> --- a/include/linux/tcp.h
>> +++ b/include/linux/tcp.h
>> @@ -136,6 +136,7 @@ struct tcp_info {
>>  	__u32	tcpi_ato;
>>  	__u32	tcpi_snd_mss;
>>  	__u32	tcpi_rcv_mss;
>> +	__u32	tcpi_sndbuf;
>>  
>>  	__u32	tcpi_unacked;
>>  	__u32	tcpi_sacked;
> 
> You cannot change tcp_info like this, this structure is used by some
> programs, and they are going to break badly.
> 

Oh, right, I forgot the ABI compatibility...
I will append it to this structure.

Thanks!