From: Patrick McHardy <kaber@trash•net>
To: Shan Wei <shanwei@cn•fujitsu.com>
Cc: David Miller <davem@davemloft•net>,
Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba•co.jp>,
eric.dumazet@gmail•com, randy.dunlap@oracle•com, mst@redhat•com,
johannes@sipsolutions•net, kuznet@ms2•inr.ac.ru,
pekkas@netcore•fi, jmorris@namei•org, yoshfuji@linux-ipv6•org,
pablo@netfilter•org, ebiederm@xmission•com, adobriyan@gmail•com,
brian.haley@hp•com, shemminger@vyatta•com,
akpm@linux-foundation•org, netfilter-devel@vger•kernel.org,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH] IPv6:Send an ICMPv6 "Fragment Reassembly Timeout" message when enabling connection track
Date: Wed, 03 Feb 2010 17:42:02 +0100 [thread overview]
Message-ID: <4B69A75A.2020908@trash.net> (raw)
In-Reply-To: <4B62A338.6020106@cn.fujitsu.com>
Shan Wei wrote:
> @@ -349,17 +378,20 @@ static int nf_ct_frag6_queue(struct nf_ct_frag6_queue *fq, struct sk_buff *skb,
> else
> fq->q.fragments = skb;
>
> - skb->dev = NULL;
> fq->q.stamp = skb->tstamp;
> fq->q.meat += skb->len;
> atomic_add(skb->truesize, &nf_init_frags.mem);
>
> /* The first fragment.
> * nhoffset is obtained from the first fragment, of course.
> + * Reserve dev for sending an ICMP "Fragment Reassembly Timeout"
> + * message.
> */
> if (offset == 0) {
> fq->nhoffset = nhoff;
> fq->q.last_in |= INET_FRAG_FIRST_IN;
> + } else {
> + skb->dev = NULL;
> }
We need to store the iif and perform a lookup later just as in IPv4
because the device is not reference counted and might disappear while
the fragments are queued.
Besides this, the patch looks good.
next prev parent reply other threads:[~2010-02-03 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 8:58 [PATCH] IPv6:Send an ICMPv6 "Fragment Reassembly Timeout" message when enabling connection track Shan Wei
2010-02-03 16:42 ` Patrick McHardy [this message]
2010-02-08 14:18 ` Shan Wei
2010-02-08 14:20 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B69A75A.2020908@trash.net \
--to=kaber@trash$(echo .)net \
--cc=adobriyan@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=brian.haley@hp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=pekkas@netcore$(echo .)fi \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=shanwei@cn$(echo .)fujitsu.com \
--cc=shemminger@vyatta$(echo .)com \
--cc=yasuyuki.kozakai@toshiba$(echo .)co.jp \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox