From: Jeff Garzik <jeff@garzik•org>
To: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel•com>
Cc: David Miller <davem@davemloft•net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"gospo@redhat•com" <gospo@redhat•com>
Subject: Re: [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter programming support
Date: Thu, 04 Feb 2010 17:55:51 -0500 [thread overview]
Message-ID: <4B6B5077.9070005@garzik.org> (raw)
In-Reply-To: <1265323938.2780.6.camel@localhost>
On 02/04/2010 05:52 PM, Peter P Waskiewicz Jr wrote:
> On Thu, 2010-02-04 at 14:34 -0800, Jeff Garzik wrote:
>> On 02/04/2010 04:26 PM, Waskiewicz Jr, Peter P wrote:
>>> On Thu, 4 Feb 2010, David Miller wrote:
>>>
>>>> From: Jeff Kirsher<jeffrey.t.kirsher@intel•com>
>>>> Date: Wed, 03 Feb 2010 23:48:13 -0800
>>>>
>>>>> +#define ETHTOOL_RXNTUPLE_ACTION_DROP -1
>>>>> + struct list_head list;
>>>>> +};
>>>>
>>>> You can't do this.
>>>>
>>>> You put the list_head here in the kernel header, which BTW can
>>>> be used by userspace too, and then you elide it in the
>>>> ethtool utility copy of the header.
>>>>
>>>> Use an encapsulator if you must inside of the kernel, but keep the
>>>> userspace visible data structure clean of RCU and list_head
>>>> kernel datastructures.
>>>
>>> Ok. I'll respin this asap. Thanks for the quick review Dave.
>>
>> Great. I'll look for the updated userspace patch, too, and put it into
>> the ethtool-2.6.34 pile (ie. ethtool-net-next).
>>
>
> I didn't plan on respinning the userspace side. I put a container
> wrapped around the flow_spec struct to do the list management in the
> kernel. This shouldn't need a change to userspace.
Well, I figured there would be some trivial tweaks and patch offsets,
because we want to keep the kernel ethtool.h and userspace
ethtool-copy.h headers in sync.
Either way, no big deal. I'll make sure net-next and ethtool match up,
after your userspace patch is applied, one way or the other.
Jeff
next prev parent reply other threads:[~2010-02-04 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 7:48 [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter programming support Jeff Kirsher
2010-02-04 7:48 ` [net-next-2.6 PATCH v2 2/3] ixgbe: Add support for the new ethtool n-tuple programming interface Jeff Kirsher
2010-02-04 7:48 ` [net-next-2.6 PATCH v2 3/3] ixgbe: Bump driver version up Jeff Kirsher
2010-02-04 17:18 ` [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter programming support David Miller
2010-02-04 21:26 ` Waskiewicz Jr, Peter P
2010-02-04 22:34 ` Jeff Garzik
2010-02-04 22:52 ` Peter P Waskiewicz Jr
2010-02-04 22:55 ` Jeff Garzik [this message]
2010-02-04 23:07 ` Peter P Waskiewicz Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6B5077.9070005@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox