public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jasper Spaans <spaans@fox-it•com>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: David Miller <davem@davemloft•net>,
	Jay Vosburgh <fubar@us•ibm.com>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	"bonding-devel@lists•sourceforge.net"
	<bonding-devel@lists•sourceforge.net>
Subject: Re: [RFC 0/4] bond hashing revised
Date: Fri, 5 Feb 2010 09:40:17 +0000	[thread overview]
Message-ID: <4B6BE781.7070107@fox-it.com> (raw)
In-Reply-To: <20100204171118.917737392@vyatta.com>

On 04/02/10 17:11, Stephen Hemminger wrote:
> These have not been tested yet. I need to try them with some
> different flows/hardware to validate.
>   
Glancing over these patches, all four of them look fine to me.

The only thing missing is some documentation in
Documentation/networking/bonding.txt (I have no idea what multiqueue is
supposed to do, but if you tell me I'll volunteer).

Cheers,
Jasper

-- 
Ir. Jasper Spaans
Fox-IT Experts in IT Security!
T: +31 (0) 15 284 79 99
KvK Haaglanden 27301624



  parent reply	other threads:[~2010-02-05  9:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-04 17:11 [RFC 0/4] bond hashing revised Stephen Hemminger
2010-02-04 17:11 ` [RFC 1/4] bond: cleanup transmit hash policy interface Stephen Hemminger
2010-02-04 17:11 ` [RFC 2/4] bond: add IPV6 layer3 hash policy support Stephen Hemminger
2010-02-04 17:11 ` [RFC 3/4] bond: support more Layer 4 protocols Stephen Hemminger
2010-02-05 10:38   ` Patrick McHardy
2010-02-05 16:42     ` Stephen Hemminger
2010-02-08 13:11       ` Patrick McHardy
2010-02-04 17:11 ` [RFC 4/4] bond: add new multiqueue hash policy Stephen Hemminger
2010-02-05  9:40 ` Jasper Spaans [this message]
2010-02-05 21:04   ` [RFC 0/4] bond hashing revised Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6BE781.7070107@fox-it.com \
    --to=spaans@fox-it$(echo .)com \
    --cc=bonding-devel@lists$(echo .)sourceforge.net \
    --cc=davem@davemloft$(echo .)net \
    --cc=fubar@us$(echo .)ibm.com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=shemminger@vyatta$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox