From: Patrick McHardy <kaber@trash•net>
To: Pablo Neira Ayuso <pablo@netfilter•org>
Cc: Ramblewski David <David.Ramblewski@atosorigin•com>,
Eric Dumazet <eric.dumazet@gmail•com>,
"netfilter-devel@vger•kernel.org"
<netfilter-devel@vger•kernel.org>,
netdev <netdev@vger•kernel.org>
Subject: Re: kernel stack trace using conntrack
Date: Thu, 18 Feb 2010 13:19:59 +0100 [thread overview]
Message-ID: <4B7D306F.9060808@trash.net> (raw)
In-Reply-To: <4B7D3022.9030405@netfilter.org>
Pablo Neira Ayuso wrote:
> Patrick McHardy wrote:
>>>> Pablo, please let me know whether you want me to apply this.
>>> ctnetlink_change_helper() also calls nf_ct_ext_add() for conntracks that
>>> are confirmed (in case of a helper update for an existing conntrack).
>>> That would also trigger the assertion. If we want to support helper
>>> assignation via ctnetlink for existing conntracks, we will need to add
>>> locking to the conntrack extension infrastructure to avoid races.
>>>
>>> I don't see a clear solution for this yet.
>> I see, this is indeed a problem. Since the helper is known at the
>> first event, we could restrict this to only allow manual assignment
>> for newly created conntracks. Most helpers probably can't properly
>> cope with connections not seen from the beginning anyways.
>
> Indeed, changing the helper in the middle of the road doesn't make too
> much sense to me either. I can send you a patch for this along today,
> I'll find some spare time to do it.
Great, thanks Pablo.
next prev parent reply other threads:[~2010-02-18 12:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7EF5DBE4C76A7B4DA655334E9F2BFD26CED7BC8D04@FRSPX100.fr01.awl.atosorigin.net>
[not found] ` <1266313889.3045.1.camel@edumazet-laptop>
[not found] ` <7EF5DBE4C76A7B4DA655334E9F2BFD26CED7BC8D54@FRSPX100.fr01.awl.atosorigin.net>
2010-02-16 11:15 ` kernel stack trace using conntrack Eric Dumazet
2010-02-16 13:33 ` Pablo Neira Ayuso
2010-02-16 13:45 ` Eric Dumazet
2010-02-18 9:37 ` Ramblewski David
2010-02-18 10:34 ` Patrick McHardy
2010-02-18 11:02 ` Pablo Neira Ayuso
2010-02-18 11:15 ` Patrick McHardy
2010-02-18 12:18 ` Pablo Neira Ayuso
2010-02-18 12:19 ` Patrick McHardy [this message]
2010-02-19 2:18 ` Pablo Neira Ayuso
2010-02-19 12:33 ` Eric Dumazet
2010-02-19 13:25 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7D306F.9060808@trash.net \
--to=kaber@trash$(echo .)net \
--cc=David.Ramblewski@atosorigin$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox