From: Dimitris Michailidis <dm@chelsio•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next 0/7] cxgb4 patches V2
Date: Tue, 23 Feb 2010 11:07:29 -0800 [thread overview]
Message-ID: <4B842771.9000506@chelsio.com> (raw)
In-Reply-To: <20100221.223049.183064491.davem@davemloft.net>
David Miller wrote:
> From: Dimitris Michailidis <dm@chelsio•com>
> Date: Thu, 18 Feb 2010 13:24:09 -0800
>
>> This is V2 of the cxgb4 patches.
>>
>> Changes since V1:
>> - Whitespace fixed as well as some additional checkpatch issues.
>> - I removed the CH_* logging wrappers. I used the new netdev_* in a handful of
>> places but mostly stayed with the dev_* functions.
>> - I added some comments to describe the register macro scheme. As a macro
>> change would involve a rather large number of LOCs I'd really like to avoid
>> changing them.
>
> I also told you to not use the non-standard S_*, V_*, etc. register
> naming convention.
>
> If you repost your driver without addressing all of the review
> feedback you've received thus far, you are wasting people's time
> because they will take time out to review your patches again
> only to find that you've haven't fixed everything you've already
> been made aware of.
>
Can you please clarify what exactly you want me to change about the macros?
I looked at a few other drivers in the tree and I saw shift macros with
_SHIFT or _SH suffixes, masks tend to have _MASK or _MSK suffixes, etc. Are
you asking me basically to change our S_, V_, etc prefixes to _SHIFT, etc
suffixes or are we talking about some other kind of change? Please bear
with me, I am trying to understand what you're asking for exactly.
next prev parent reply other threads:[~2010-02-23 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 21:24 [PATCH net-next 0/7] cxgb4 patches V2 Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 1/7] cxgb4: Add register and message definitions Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 2/7] cxgb4: Add FW API definitions Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 3/7] cxgb4: Add HW and FW support code Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 4/7] cxgb4: Add packet queues and packet DMA code Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 5/7] cxgb4: Add remaining driver headers and L2T management Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 6/7] cxgb4: Add main driver file and driver Makefile Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 7/7] net: Hook up cxgb4 to Kconfig and Makefile Dimitris Michailidis
2010-02-22 6:30 ` [PATCH net-next 0/7] cxgb4 patches V2 David Miller
2010-02-23 19:07 ` Dimitris Michailidis [this message]
2010-02-23 22:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B842771.9000506@chelsio.com \
--to=dm@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox