Subject: Re: [RFC PATCH net-next 1/5]IPv6:netfilter: defrag:Introduce net namespace

From: Patrick McHardy <[email-masked]>
Date: Wed, 24 Feb 2010 15:05:15 +0100

Shan Wei wrote:
> Alexey Dobriyan wrote, at 02/24/2010 03:48 PM:
>>> -		.procname	= "nf_conntrack_frag6_timeout",
>>> -		.data		= &nf_init_frags.timeout,
>>> -		.maxlen		= sizeof(unsigned int),
>>> -		.mode		= 0644,
>>> -		.proc_handler	= proc_dointvec_jiffies,
>> Why are you removing sysctls?
> 
> Because, after introduced net namespace, we can use net->ipv6.frags to 
> manage IPv6 conntrack fragment queue instead of nf_init_frags. 
> And sysctls of ip6frag_low_thresh, ip6frag_time and ip6frag_high_thresh 
> also can control IPv6 conntrack fragment queue.
> 
> So, private member of nf_init_frags becomes redundant, and remove these sysctls. 

You can't simply remove them without a warning, people might be
using them.