Subject: Re: [net-next-2.6 PATCH] ethtool: Add n-tuple string length to drvinfo and return it

From: Jeff Garzik <[email-masked]>
Date: Fri, 26 Feb 2010 08:05:19 -0500

On 02/26/2010 07:20 AM, David Miller wrote:
> From: Jeff Kirsher<[email-masked]>
> Date: Fri, 26 Feb 2010 03:54:20 -0800
>
>> From: Peter Waskiewicz<[email-masked]>
>>
>> The drvinfo struct should include the number of strings that
>> get_rx_ntuple will return.  It will be variable if an underlying
>> driver implements its own get_rx_ntuple routine, so userspace
>> needs to know how much data is coming.
>>
>> Signed-off-by: Peter P Waskiewicz Jr<[email-masked]>
>> Signed-off-by: Jeff Kirsher<[email-masked]>
>
> Applied.

NAK.  Did you even read the patch?

We don't increase the size of struct ethtool_drvinfo, _especially_ by 
sticking struct members into the middle of the struct.

What do you think 'reserved' is for???

	Jeff