From: Franco Fichtner <franco@lastsummer•de>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel•com>
Cc: Franco Fichtner <franco@lastsummer•de>,
Netdev <netdev@vger•kernel.org>,
"Allan, Bruce W" <bruce.w.allan@intel•com>
Subject: Re: e1000e: reset of tx_queue_len
Date: Wed, 03 Mar 2010 15:22:59 +0100 [thread overview]
Message-ID: <4B8E70C3.1020501@lastsummer.de> (raw)
In-Reply-To: <alpine.WNT.2.00.1003021020160.2888@jbrandeb-desk1.amr.corp.intel.com>
Hi Jesse,
> Its possible we should just remove this code from the in-kernel
> driver, as I don't think many other drivers mess with the tx_queue_len
> either. We did introduce the code to fix some users complaints about the
> amount of work that can get queued up in the hardware with tx_queue_len =
> 1000 when at 10/100 speeds.
>
I've tested the changes you suggested and now tx_queue_len
is no longer reset. I have also prepared a patch for net-next
for you to sign or ack (or nack) because I'd like to see this go,
also.
Thanks again,
Franco
prev parent reply other threads:[~2010-03-03 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 17:44 e1000e: reset of tx_queue_len Franco Fichtner
2010-03-02 18:27 ` Brandeburg, Jesse
2010-03-02 19:52 ` Franco Fichtner
2010-03-03 14:22 ` Franco Fichtner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8E70C3.1020501@lastsummer.de \
--to=franco@lastsummer$(echo .)de \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox