Subject: Re: [PATCH v4] ethtool: Add direct access to ops->get_sset_count

From: Jeff Garzik <[email-masked]>
Date: Thu, 04 Mar 2010 08:23:05 -0500

On 03/04/2010 03:51 AM, Jeff Kirsher wrote:
> From: Jeff Garzik<[email-masked]>
>
> This patch is an alternative approach for accessing string
> counts, vs. the drvinfo indirect approach.  This way the drvinfo
> space doesn't run out, and we don't break ABI later.
>
> Signed-off-by: Jeff Garzik<[email-masked]>
> Signed-off-by: Peter P Waskiewicz Jr<[email-masked]>
> Signed-off-by: Jeff Kirsher<[email-masked]>
> ---
>
>   include/linux/ethtool.h |   17 +++++++++--
>   net/core/ethtool.c      |   72 +++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 86 insertions(+), 3 deletions(-)

Both patches look good to me.  There is a cosmetic issue of needing to 
sync up userspace and kernel ethtool.h WRT whitespace and deleted 
constants, but I can do that after DaveM applies this patch.

Waiting for upstream application, or other objections...