Subject: Re: [PATCH] s2io: fixing DBG_PRINT() macro

From: Breno Leitao <[email-masked]>
Date: Fri, 05 Mar 2010 11:21:06 -0300

David, 

Due my mistake I didn't send this patch to Sreenivasa. After
sending this patch to netdev, I forward to him, and
he acked it privately.

Sorry for the confusion. 
Thanks, 
Breno

[email-masked] wrote:
> Patch 9e39f7c5b311a306977c5471f9e2ce4c456aa038 changed the
> DBG_PRINT() macro and the if clause was changed. It means
> that currently all the DBG_PRINT are being printed, flooding
> the kernel log buffer with thinkgs like:
> 
> s2io: eth6: Next block at: c0000000b9c90000
> s2io: eth6: In Neterion Tx routine
> 
> This patch just fixes the if clause condition.
> 
> Signed-off-by: Breno Leitao <[email-masked]>
> ---
>  drivers/net/s2io.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/s2io.h b/drivers/net/s2io.h
> index 47c36e0..3b6f45d 100644
> --- a/drivers/net/s2io.h
> +++ b/drivers/net/s2io.h
> @@ -65,7 +65,7 @@ static int debug_level = ERR_DBG;
> 
>  /* DEBUG message print. */
>  #define DBG_PRINT(dbg_level, fmt, args...) do {			\
> -	if (dbg_level >= debug_level)				\
> +	if (dbg_level <= debug_level)				\
>  		pr_info(fmt, ##args);				\
>  	} while (0)
>