From: John Fastabend <john.r.fastabend@intel•com>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: David Miller <davem@davemloft•net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"gospo@redhat•com" <gospo@redhat•com>
Subject: Re: [net-next-2.6 PATCH v2] net: consolidate netif_needs_gso() checks
Date: Mon, 08 Mar 2010 08:56:47 -0800 [thread overview]
Message-ID: <4B952C4F.8000504@intel.com> (raw)
In-Reply-To: <20100307014324.GA19589@gondor.apana.org.au>
Herbert Xu wrote:
> On Sat, Mar 06, 2010 at 11:27:50AM -0800, John Fastabend wrote:
>
>> It looks like dev_gso_segment() could be used to "Verify header
>> integrity only" according to the comment? If this is true I think the
>> logic should probably be
>>
>> if (netif_needs_gso(dev, skb)) {
>> if (unlikely(dev_gso_segment(skb)))
>> goto out_kfree_skb;
>> if (skb->next)
>> goto gso;
>> } do your thing
>>
>>
>>
>> That way we linearize the skb if necessary in the case were
>> dev_gso_segment() only verifies the header and does not return a list of
>> segments.
>>
>
> If we needed to linearise the skb then dev_gso_segment should
> perform the segmentation. Is there a case where it doesn't?
>
> Cheers,
Nope as far as I can tell all cases are covered my concerns were
unfounded. Thanks for the review, I'll get this updated and resent.
-John.
prev parent reply other threads:[~2010-03-08 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 0:20 [net-next-2.6 PATCH v2] net: consolidate netif_needs_gso() checks Jeff Kirsher
2010-02-27 11:27 ` David Miller
2010-02-27 15:52 ` Herbert Xu
2010-02-27 16:17 ` David Miller
2010-02-28 0:29 ` Herbert Xu
2010-02-28 8:29 ` David Miller
2010-02-28 8:30 ` David Miller
2010-03-06 19:27 ` John Fastabend
2010-03-07 1:43 ` Herbert Xu
2010-03-08 16:56 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B952C4F.8000504@intel.com \
--to=john.r.fastabend@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox