From: Jeff Garzik <jeff@garzik•org>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: Joe Perches <joe@perches•com>, David Miller <davem@davemloft•net>,
ajitk@serverengines•com, ajitkhaparde@gmail•com,
netdev@vger•kernel.org
Subject: Re: [PATCH] ethtool.h: Add "structs are public" disclaimer comment
Date: Sun, 14 Mar 2010 14:38:19 -0400 [thread overview]
Message-ID: <4B9D2D1B.2080004@garzik.org> (raw)
In-Reply-To: <1268589034.2664.68.camel@localhost>
On 03/14/2010 01:50 PM, Ben Hutchings wrote:
> On Sun, 2010-03-14 at 09:17 -0700, Joe Perches wrote:
>> On Sat, 2010-03-13 at 18:11 -0800, David Miller wrote:
>>> For the millionth time, you cannot change these datastructures
>>> like this without breaking all existing userspace applications
>>> out there.
>>
>> Maybe this might help reduce the broken record repetitiveness.
>>
>> Signed-off-by: Joe Perches<joe@perches•com>
>> ---
>> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
>> index b33f316..9bd7583 100644
>> --- a/include/linux/ethtool.h
>> +++ b/include/linux/ethtool.h
>> @@ -10,6 +10,15 @@
>> * Portions Copyright (C) Sun Microsystems 2008
>> */
>>
>> +/*
>> + * Do not submit patches that change the public structs not guarded by
>> + * #ifdef __KERNEL__ in this file.
>> + *
>> + * In case the use of __u8, __u16, __u32 and other reserved types don't
>> + * mean much to you, these structs are used by user-space applications
>> + * and must not be changed.
>> + */
>
> This comment is not quite correct: reserved fields may be replaced so
> long as the structure size and offsets of other fields stay the same.
I don't think we need this in every ABI-related header, though, do we?
Jeff
next prev parent reply other threads:[~2010-03-14 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 1:43 [RFC PATCH net-2.6] net/ethtool: add multiple queue support to {get,set}_ringparams Ajit Khaparde
2010-03-14 2:11 ` David Miller
2010-03-14 16:17 ` [PATCH] ethtool.h: Add "structs are public" disclaimer comment Joe Perches
2010-03-14 17:50 ` Ben Hutchings
2010-03-14 18:38 ` Jeff Garzik [this message]
2010-03-14 22:08 ` David Miller
2010-03-14 4:21 ` [RFC PATCH net-2.6] net/ethtool: add multiple queue support to {get,set}_ringparams Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9D2D1B.2080004@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=ajitk@serverengines$(echo .)com \
--cc=ajitkhaparde@gmail$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=joe@perches$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox