From: "\"YOSHIFUJI Hideaki (吉藤 英明)\"" <hideaki@yoshifuji•org>
To: Patrick McHardy <kaber@trash•net>
Cc: Alexey Dobriyan <adobriyan@gmail•com>,
Stephen Hemminger <shemminger@vyatta•com>,
Ben Hutchings <bhutchings@solarflare•com>,
Andreas Henriksson <andreas@fatal•se>, jamal <hadi@cyberus•ca>,
netdev@vger•kernel.org
Subject: Re: [PATCH] xtables: make XT_ALIGN() usable in exported headers
Date: Thu, 01 Apr 2010 21:25:25 +0900 [thread overview]
Message-ID: <4BB490B5.1040200@yoshifuji.org> (raw)
In-Reply-To: <4BB48C50.2000000@trash.net>
I think it is better to solicit comments on LKML.
This is not a new issue but rather a common one
(e.g. CMSG_ALIGN uses its own definition).
Regards,
--yoshfuji
(2010/04/01 21:06), Patrick McHardy wrote:
> Alexey Dobriyan wrote:
>> On Thu, Apr 1, 2010 at 1:50 PM, Patrick McHardy<kaber@trash•net> wrote:
>>> I can't think of anything but to restore the XT_ALIGN macro.
>>> We could add a XT_ALIGN definition to xtables.h, but that might
>>> still leave problems for other users.
>>>
>>> Alexey, do you have any better suggestions?
>>
>> I like __KERNEL_ALIGN trick.
>>
>> Sorry for attachment, my patch sending facility is broke.
>> Tested on iptables compilation.
>>
>
> Seems fine to me, thanks. I'll wait a bit for others to comment.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-04-01 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 12:02 [PATCH] xtables: make XT_ALIGN() usable in exported headers Alexey Dobriyan
2010-04-01 12:06 ` Patrick McHardy
2010-04-01 12:25 ` "YOSHIFUJI Hideaki (吉藤 英明)" [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB490B5.1040200@yoshifuji.org \
--to=hideaki@yoshifuji$(echo .)org \
--cc=adobriyan@gmail$(echo .)com \
--cc=andreas@fatal$(echo .)se \
--cc=bhutchings@solarflare$(echo .)com \
--cc=hadi@cyberus$(echo .)ca \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox