From: Koki Sanagi <sanagi.koki@jp•fujitsu.com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev@vger•kernel.org, izumi.taku@jp•fujitsu.com,
kaneshige.kenji@jp•fujitsu.com, davem@davemloft•net,
nhorman@tuxdriver•com, jeffrey.t.kirsher@intel•com,
jesse.brandeburg@intel•com, bruce.w.allan@intel•com,
alexander.h.duyck@intel•com, peter.p.waskiewicz.jr@intel•com,
john.ronciak@intel•com
Subject: Re: [RFC PATCH 2/2] netdev: an usage example on igb
Date: Tue, 06 Apr 2010 14:40:52 +0900 [thread overview]
Message-ID: <4BBAC964.4070505@jp.fujitsu.com> (raw)
In-Reply-To: <1270456224.1971.15.camel@edumazet-laptop>
(2010/04/05 17:30), Eric Dumazet wrote:
> Le lundi 05 avril 2010 à 15:54 +0900, Koki Sanagi a écrit :
>> This patch is usage example of previous patch's buffer on igb.
>> The output is like below.
>>
>> # cat /sys/kernel/debug/ndrvbuf/igb-trace-0000\:03\:00.0/buffer
>> [ 1] 50462.369207: clean_tx qidx=1 ntu=154->156
>> [ 0] 50462.369241: clean_rx qidx=0 ntu=111->112
>> [ 0] 50462.369250: xmit qidx=1 ntu=156->158
>> [ 1] 50462.369256: clean_tx qidx=1 ntu=156->158
>> [ 1] 50462.369342: clean_rx qidx=0 ntu=113->114
>> [ 1] 50462.369439: clean_rx qidx=0 ntu=114->115
>>
>> This example outputs original print style, because it sets original print
>> function(igb_trace_read) when registered.
>>
>> register_ndrvbuf(buname, 1000000, igb_trace_read);
>>
>> If you set NULL to arg3, outputs by ndrvbuf default style.
>> If you set 0 to size(arg2), recording is disabled at first(but small buffer is
>> alloced).
>> When you set non-zero to size, recording becomes enabled.
>>
>> Signed-off-by: Koki Sanagi<sanagi.koki@jp•fujitsu.com>
>> ---
>> drivers/net/igb/Makefile | 2 +-
>> drivers/net/igb/igb.h | 1 +
>> drivers/net/igb/igb_main.c | 10 +++++-
>> drivers/net/igb/igb_trace.c | 81 +++++++++++++++++++++++++++++++++++++++++++
>> drivers/net/igb/igb_trace.h | 21 +++++++++++
>> 5 files changed, 113 insertions(+), 2 deletions(-)
>>
>
> This depends on NDRVBUF, yet I see no Kconfig change in this patch.
>
This igb can exist without ndrvbuf.
If ndrvbuf modules is not loaded, igb operates originally.
So this doesn't depend on ndrvbuf.
prev parent reply other threads:[~2010-04-06 5:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 6:50 [RFC PATCH 0/2] netdev: implement a buffer to log network driver's information Koki Sanagi
2010-04-05 6:52 ` [RFC PATCH 1/2] netdev: buffer infrastructure " Koki Sanagi
2010-04-05 8:42 ` Eric Dumazet
2010-04-05 19:31 ` David Miller
2010-04-06 0:10 ` Neil Horman
2010-04-06 5:43 ` Koki Sanagi
2010-04-05 6:54 ` [RFC PATCH 2/2] netdev: an usage example on igb Koki Sanagi
2010-04-05 8:30 ` Eric Dumazet
2010-04-06 5:40 ` Koki Sanagi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBAC964.4070505@jp.fujitsu.com \
--to=sanagi.koki@jp$(echo .)fujitsu.com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=izumi.taku@jp$(echo .)fujitsu.com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=kaneshige.kenji@jp$(echo .)fujitsu.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox