From: Shan Wei <shanwei@cn•fujitsu.com>
To: Herbert Xu <herbert@gondor•hengli.com.au>
Cc: "David Miller" <davem@davemloft•net>,
"yoshfuji@linux-ipv6•org >> YOSHIFUJI Hideaki"
<yoshfuji@linux-ipv6•org>, 魏勇军 <yjwei@cn•fujitsu.com>,
vladislav.yasevich@hp•com, kuznet@ms2•inr.ac.ru,
pekkas@netcore•fi, jmorris@namei•org,
"Patrick McHardy" <kaber@trash•net>,
eric.dumazet@gmail•com, sri@us•ibm.com,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
linux-sctp@vger•kernel.org
Subject: Re: [PATCH BUG-FIX] ipv6: allow to send packet after receiving ICMPv6 Too Big message with MTU field less than IPV6_MIN_MTU
Date: Mon, 19 Apr 2010 14:49:02 +0800 [thread overview]
Message-ID: <4BCBFCDE.7090206@cn.fujitsu.com> (raw)
In-Reply-To: <20100419035535.GA7011@gondor.apana.org.au>
Herbert Xu wrote, at 04/19/2010 11:55 AM:
>
> The patch looks good to me.
Thanks for reviewing this patch.
> If we wanted to optimise the allfrags case it may be better
> to reserve the space beforehand and generate the fragment header
> at the same time as we're doing the IPv6 header.
>
> But it can't be all that important as it's been broken for so
> many years.
If somebody needs one patch to fix the broken,
I am pleased to do so.
--
Best Regards
-----
Shan Wei
>
> Thanks,
next prev parent reply other threads:[~2010-04-19 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 2:58 [PATCH BUG-FIX] ipv6: allow to send packet after receiving ICMPv6 Too Big message with MTU field less than IPV6_MIN_MTU Shan Wei
2010-04-19 3:55 ` Herbert Xu
2010-04-19 6:49 ` Shan Wei [this message]
2010-04-22 5:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCBFCDE.7090206@cn.fujitsu.com \
--to=shanwei@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pekkas@netcore$(echo .)fi \
--cc=sri@us$(echo .)ibm.com \
--cc=vladislav.yasevich@hp$(echo .)com \
--cc=yjwei@cn$(echo .)fujitsu.com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox