Subject: Re: [PATCH 2/2] sky2: add support for receive hashing

From: Jeff Garzik <[email-masked]>
Date: Thu, 22 Apr 2010 21:32:26 -0400

On 04/22/2010 07:42 PM, Stephen Hemminger wrote:
> +static int sky2_set_flags(struct net_device *dev, u32 data)
> +{
> +	struct sky2_port *sky2 = netdev_priv(dev);
> +
> +	if (data&  ETH_FLAG_LRO)
> +		return -EOPNOTSUPP;
> +
> +	if (data&  ETH_FLAG_NTUPLE)
> +		return -EOPNOTSUPP;

Minor nit:  you don't need separate tests for each bit.

	Jeff