From: Patrick McHardy <kaber@trash•net>
To: Simon Horman <horms@verge•net.au>
Cc: lvs-devel@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, netfilter@vger•kernel.org,
Wensong Zhang <wensong@linux-vs•org>,
Julius Volz <julius.volz@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Hannes Eder <heder@google•com>,
Netfilter Development Mailinglist
<netfilter-devel@vger•kernel.org>
Subject: Re: [patch v2.2 1/4] [PATCH v2.1 1/4] netfilter: xt_ipvs (netfilter matcher for IPVS)
Date: Sat, 01 May 2010 18:18:07 +0200 [thread overview]
Message-ID: <4BDC543F.7060500@trash.net> (raw)
In-Reply-To: <20100501032120.298829234@vergenet.net>
Simon Horman wrote:
> @@ -0,0 +1,25 @@
> +#ifndef _XT_IPVS_H
> +#define _XT_IPVS_H 1
You don't need to define a value.
> +config NETFILTER_XT_MATCH_IPVS
> + tristate '"ipvs" match support'
> + depends on IP_VS
> + depends on NETFILTER_ADVANCED
> + help
> + This option allows you to match against IPVS properties of a packet.
> +
> + If unsure, say N.
You're using conntrack symbols, so this seems to need a dependency
on NF_CONNTRACK.
> +static bool ipvs_mt_check(const struct xt_mtchk_param *par)
We've changed the signature to "int" in nf-next to be able to
return errno codes. Please rebase your patches onto nf-next-2.6.git.
Please also CC netfilter-devel at least for those parts that affect
non-IPVS netfilter.
> +{
> + if (par->family != NFPROTO_IPV4
> +#ifdef CONFIG_IP_VS_IPV6
> + && par->family != NFPROTO_IPV6
> +#endif
> + ) {
> + pr_info("protocol family %u not supported\n", par->family);
> + return false;
> + }
> +
> + return true;
> +}
next prev parent reply other threads:[~2010-05-01 16:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-01 3:20 [patch v2.2 0/4] IPVS full NAT support + netfilter 'ipvs' match support Simon Horman
2010-05-01 3:20 ` [patch v2.2 1/4] [PATCH v2.1 1/4] netfilter: xt_ipvs (netfilter matcher for IPVS) Simon Horman
2010-05-01 16:18 ` Patrick McHardy [this message]
2010-05-03 11:29 ` Hannes Eder
2010-06-22 7:13 ` Simon Horman
2010-07-20 12:44 ` Hannes Eder
2010-07-20 23:34 ` Simon Horman
2010-05-01 3:20 ` [patch v2.2 2/4] [PATCH v2.1 2/4] IPVS: make friends with nf_conntrack Simon Horman
2010-05-01 16:19 ` Patrick McHardy
2010-05-01 3:20 ` [patch v2.2 3/4] [PATCH v2.1 3/4] IPVS: make FTP work with full NAT support Simon Horman
2010-05-01 16:26 ` Patrick McHardy
2010-05-01 3:20 ` [patch v2.2 4/4] [PATCH v2.1 4/4] libxt_ipvs: user-space lib for netfilter matcher xt_ipvs Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDC543F.7060500@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=heder@google$(echo .)com \
--cc=horms@verge$(echo .)net.au \
--cc=julius.volz@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=netfilter@vger$(echo .)kernel.org \
--cc=wensong@linux-vs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox