From: Dimitris Michailidis <dm@chelsio•com>
To: Ben Greear <greearb@candelatech•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next 3/3] cxgb4: report GRO stats with ethtool -S
Date: Tue, 11 May 2010 01:45:36 -0700 [thread overview]
Message-ID: <4BE91930.5040109@chelsio.com> (raw)
In-Reply-To: <4BE8C8CD.1000200@candelatech.com>
Ben Greear wrote:
> On 05/10/2010 06:58 PM, Dimitris Michailidis wrote:
>> Signed-off-by: Dimitris Michailidis<dm@chelsio•com>
>
> One of these is on-wire packets? If so, maybe use the same
> string as Intel ixgbe uses:
>
> rx_pkts_nic # Pkts received by NIC from wire.
> rx_bytes_nic # Bytes received by NIC from wire.
> tx_pkts_nic # Pkts transmitted to wire by NIC.
> tx_bytes_nic # Bytes transmitted to wire by NIC.
The two stats I'm adding don't correspond to any of the 4 above. One is the
superpackets coming out of GRO, the other is packets merged by GRO to create
the superpackets.
>
> Thanks,
> Ben
>
>
>
>> ---
>> drivers/net/cxgb4/cxgb4_main.c | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/cxgb4/cxgb4_main.c
>> b/drivers/net/cxgb4/cxgb4_main.c
>> index 80c3fc5..90d375b 100644
>> --- a/drivers/net/cxgb4/cxgb4_main.c
>> +++ b/drivers/net/cxgb4/cxgb4_main.c
>> @@ -859,6 +859,8 @@ static char stats_strings[][ETH_GSTRING_LEN] = {
>> "RxCsumGood ",
>> "VLANextractions ",
>> "VLANinsertions ",
>> + "GROpackets ",
>> + "GROmerged ",
>> };
>>
>> static int get_sset_count(struct net_device *dev, int sset)
>> @@ -922,6 +924,8 @@ struct queue_port_stats {
>> u64 rx_csum;
>> u64 vlan_ex;
>> u64 vlan_ins;
>> + u64 gro_pkts;
>> + u64 gro_merged;
>> };
>>
>> static void collect_sge_port_stats(const struct adapter *adap,
>> @@ -938,6 +942,8 @@ static void collect_sge_port_stats(const struct
>> adapter *adap,
>> s->rx_csum += rx->stats.rx_cso;
>> s->vlan_ex += rx->stats.vlan_ex;
>> s->vlan_ins += tx->vlan_ins;
>> + s->gro_pkts += rx->stats.lro_pkts;
>> + s->gro_merged += rx->stats.lro_merged;
>> }
>> }
>>
>
>
next prev parent reply other threads:[~2010-05-11 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 1:58 [PATCH net-next 1/3] cxgb4: configure HW VLAN extraction through FW Dimitris Michailidis
2010-05-11 1:58 ` [PATCH net-next 2/3] cxgb4: report the PCIe link speed Dimitris Michailidis
2010-05-11 1:58 ` [PATCH net-next 3/3] cxgb4: report GRO stats with ethtool -S Dimitris Michailidis
2010-05-11 3:02 ` Ben Greear
2010-05-11 8:45 ` Dimitris Michailidis [this message]
2010-05-13 6:32 ` David Miller
2010-05-13 6:32 ` [PATCH net-next 2/3] cxgb4: report the PCIe link speed David Miller
2010-05-13 6:32 ` [PATCH net-next 1/3] cxgb4: configure HW VLAN extraction through FW David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE91930.5040109@chelsio.com \
--to=dm@chelsio$(echo .)com \
--cc=greearb@candelatech$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox