Subject: Re: [net-next-2.6 V6 PATCH 1/2] Add netlink support for virtual port management (was iovnl)

From: Patrick McHardy <[email-masked]>
Date: Thu, 13 May 2010 22:49:00 +0200

Chris Wright wrote:
> * Patrick McHardy ([email-masked]) wrote:
>>> +	} else  {
>>> +		err = rtnl_vf_port_fill_nest(skb, dev, -1);
>> What does -1 mean?
> 
> It means no VFs.  Could be made a macro/enum constant

Why call rtnl_vg_port_fill_nest at all in that case? It even
calls the ndo_get_vf_port() callback.