From: Patrick McHardy <kaber@trash•net>
To: Chris Wright <chrisw@redhat•com>
Cc: Scott Feldman <scofeldm@cisco•com>,
davem@davemloft•net, netdev@vger•kernel.org, arnd@arndb•de
Subject: Re: [net-next-2.6 V6 PATCH 1/2] Add netlink support for virtual port management (was iovnl)
Date: Thu, 13 May 2010 23:11:53 +0200 [thread overview]
Message-ID: <4BEC6B19.1040808@trash.net> (raw)
In-Reply-To: <20100513210828.GD30483@x200.localdomain>
Chris Wright wrote:
> * Patrick McHardy (kaber@trash•net) wrote:
>> Chris Wright wrote:
>>> * Patrick McHardy (kaber@trash•net) wrote:
>>>>> + } else {
>>>>> + err = rtnl_vf_port_fill_nest(skb, dev, -1);
>>>> What does -1 mean?
>>> It means no VFs. Could be made a macro/enum constant
>> Why call rtnl_vg_port_fill_nest at all in that case? It even
>> calls the ndo_get_vf_port() callback.
>
> For the case where port profile is set on net dev that does not
> have VFs (e.g. the enic case in 2/2).
Thanks for the explanation. I guess a enum constant would be nice
to have. But the bigger problem is the asymetrical message
parsing/construction.
BTW:
> +enum {
> + VF_PORT_REQUEST_PREASSOCIATE = 0,
> + VF_PORT_REQUEST_PREASSOCIATE_RR,
> + VF_PORT_REQUEST_ASSOCIATE,
> + VF_PORT_REQUEST_DISASSOCIATE,
> +};
Do multiple of these commands have to be issued in order to
reach "associated" state? That also wouldn't fit into the
rtnetlink design, which contains state, not commands.
next prev parent reply other threads:[~2010-05-13 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 20:17 [net-next-2.6 V6 PATCH 0/2] Add virtual port netlink support Scott Feldman
2010-05-13 20:17 ` [net-next-2.6 V6 PATCH 1/2] Add netlink support for virtual port management (was iovnl) Scott Feldman
2010-05-13 20:28 ` Chris Wright
2010-05-13 20:40 ` Patrick McHardy
2010-05-13 20:46 ` Chris Wright
2010-05-13 20:49 ` Patrick McHardy
2010-05-13 21:08 ` Chris Wright
2010-05-13 21:11 ` Patrick McHardy [this message]
2010-05-13 21:18 ` Chris Wright
2010-05-13 21:23 ` Patrick McHardy
2010-05-14 7:17 ` Arnd Bergmann
2010-05-13 21:30 ` Scott Feldman
2010-05-14 10:47 ` Patrick McHardy
2010-05-13 20:17 ` [net-next-2.6 V6 PATCH 2/2] Add ndo_{set|get}_vf_port support for enic dynamic vnics Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEC6B19.1040808@trash.net \
--to=kaber@trash$(echo .)net \
--cc=arnd@arndb$(echo .)de \
--cc=chrisw@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=scofeldm@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox