From: Patrick McHardy <kaber@trash•net>
To: Scott Feldman <scofeldm@cisco•com>
Cc: Arnd Bergmann <arnd@arndb•de>,
davem@davemloft•net, netdev@vger•kernel.org, chrisw@redhat•com
Subject: Re: [net-next-2.6 V7 PATCH 1/2] Add netlink support for virtual port management (was iovnl)
Date: Fri, 14 May 2010 19:26:42 +0200 [thread overview]
Message-ID: <4BED87D2.3070308@trash.net> (raw)
In-Reply-To: <C812D414.3180C%scofeldm@cisco.com>
Scott Feldman wrote:
> On 5/14/10 9:42 AM, "Patrick McHardy" <kaber@trash•net> wrote:
>
>> Arnd Bergmann wrote:
>>> Maybe a better structure would be to separate the two cases, also allowing
>>> a port profile to be associated with both the PF and with each of its VFs?
>>>
>>> Something like this:
>>>
>>> [IFLA_NUM_VF]
>>> [IFLA_VF_PORTS]
>>> [IFLA_VF_PORT]
>>> [IFLA_VF_PORT_*], ...
>>> [IFLA_VF_PORT]
>>> [IFLA_VF_PORT_*], ...
>>> [IFLA_PORT_SELF]
>>> [IFLA_VF_PORT_*], ...
>> That would also be fine.
>
> I want to make sure I've got this right before starting on ver8 of patch:
>
> - we'll use the layout listed above
>
> - RTM_SETLINK msg includes the full nested layout
>
> - contains IFLA_VF_PORTs for all VFs of a PF
> - OR, contains IFLA_PORT_SELF if PF is it's own VF
>
> - it's up to the receiver to compare for changes for each VF
>
> - RTM_GETLINK msg includes the full nested layout
>
> - same rules as RTM_SETLINK above
>
> I think we should redo the other IFLA_VF_xxx msgs in the same style. I'm
> not going to tackle that for IFLA_VF_PORTS patch, but it would be a good
> followup patch.
Agreed.
> Do we have a plan?
That sounds good to me. If you have any netlink related questions,
just let me know.
next prev parent reply other threads:[~2010-05-14 17:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 1:35 [net-next-2.6 V7 PATCH 0/2] Add virtual port netlink support Scott Feldman
2010-05-14 1:35 ` [net-next-2.6 V7 PATCH 1/2] Add netlink support for virtual port management (was iovnl) Scott Feldman
2010-05-14 10:58 ` Patrick McHardy
2010-05-14 12:12 ` Arnd Bergmann
2010-05-14 16:42 ` Patrick McHardy
2010-05-14 17:19 ` Scott Feldman
2010-05-14 17:26 ` Patrick McHardy [this message]
2010-05-14 17:29 ` Arnd Bergmann
2010-05-14 17:46 ` Scott Feldman
2010-05-14 18:09 ` Patrick McHardy
2010-05-14 18:25 ` Chris Wright
2010-05-14 18:46 ` Patrick McHardy
2010-05-14 18:48 ` Chris Wright
2010-05-14 18:50 ` Patrick McHardy
2010-05-14 20:56 ` Williams, Mitch A
2010-05-14 23:43 ` Chris Wright
2010-05-14 17:35 ` Chris Wright
2010-05-14 17:54 ` Scott Feldman
2010-05-14 1:35 ` [net-next-2.6 V7 PATCH 2/2] Add ndo_{set|get}_vf_port support for enic dynamic vnics Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BED87D2.3070308@trash.net \
--to=kaber@trash$(echo .)net \
--cc=arnd@arndb$(echo .)de \
--cc=chrisw@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=scofeldm@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox