From: Patrick McHardy <kaber@trash•net>
To: Jan Engelhardt <jengelh@medozas•de>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>,
netfilter-devel@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCHv2] netfilter: Remove skb_is_nonlinear check from nf_conntrack_sip
Date: Fri, 14 May 2010 20:45:59 +0200 [thread overview]
Message-ID: <4BED9A67.5070204@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1005142032270.13800@obet.zrqbmnf.qr>
Jan Engelhardt wrote:
> On Friday 2010-05-14 20:13, Patrick McHardy wrote:
>> Jason Gunthorpe wrote:
>>> At least the XEN net front driver always produces non linear skbs,
>>> so the SIP module does nothing at all when used with that NIC.
>>>
>>> Unconditionally linearize the skb..
>>>
>>> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
>>> ---
>>> net/netfilter/nf_conntrack_sip.c | 9 +++------
>>> 1 files changed, 3 insertions(+), 6 deletions(-)
>>>
>>> Patrick/Jan, thanks.. This is what I wanted to do in the first place,
>>> but I couldn't convince myself it was safe, as no other nf code does
>>> this..
>> Your patch is based on an old version, the current version also
>> supports TCP. I'll commit this patch to my tree after some testing.
>
> nf_defrag defragments the packets, but then they're still non-linear?
> I'm clearly missing something, could somenoe elaborate?
We're talking about packets with non-linear data, which is unrelated
to fragments. Reassembled fragments are non-linear as well though.
prev parent reply other threads:[~2010-05-14 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 18:01 [PATCHv2] netfilter: Remove skb_is_nonlinear check from nf_conntrack_sip Jason Gunthorpe
2010-05-14 18:13 ` Patrick McHardy
2010-05-14 18:26 ` Jason Gunthorpe
2010-05-14 18:42 ` Patrick McHardy
2010-05-14 19:26 ` Patrick McHardy
2010-05-14 19:33 ` Jan Engelhardt
2010-05-14 19:41 ` Patrick McHardy
2010-05-14 19:56 ` Jason Gunthorpe
2010-05-14 18:33 ` Jan Engelhardt
2010-05-14 18:45 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BED9A67.5070204@trash.net \
--to=kaber@trash$(echo .)net \
--cc=jengelh@medozas$(echo .)de \
--cc=jgunthorpe@obsidianresearch$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox