From: Shan Wei <shanwei@cn•fujitsu.com>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH BUGFIX ] ipv6: fix the bug of address check
Date: Tue, 18 May 2010 08:50:37 +0800 [thread overview]
Message-ID: <4BF1E45D.5000409@cn.fujitsu.com> (raw)
In-Reply-To: <20100517103134.06160257@nehalam>
Stephen Hemminger wrote, at 05/18/2010 01:31 AM:
>
> Why not this instead. I don't like depending on the value of the
> loop variable in the hlist_for_each()
>
> --- a/net/ipv6/addrconf.c 2010-05-17 10:27:58.218628126 -0700
> +++ b/net/ipv6/addrconf.c 2010-05-17 10:29:46.012198338 -0700
> @@ -1274,7 +1274,7 @@ static int ipv6_count_addresses(struct i
> int ipv6_chk_addr(struct net *net, struct in6_addr *addr,
> struct net_device *dev, int strict)
> {
> - struct inet6_ifaddr *ifp = NULL;
> + struct inet6_ifaddr *ifp;
> struct hlist_node *node;
> unsigned int hash = ipv6_addr_hash(addr);
>
> @@ -1283,15 +1283,16 @@ int ipv6_chk_addr(struct net *net, struc
> if (!net_eq(dev_net(ifp->idev->dev), net))
> continue;
> if (ipv6_addr_equal(&ifp->addr, addr) &&
> - !(ifp->flags&IFA_F_TENTATIVE)) {
> - if (dev == NULL || ifp->idev->dev == dev ||
> - !(ifp->scope&(IFA_LINK|IFA_HOST) || strict))
> - break;
> + !(ifp->flags&IFA_F_TENTATIVE) &&
> + (dev == NULL || ifp->idev->dev == dev ||
> + !(ifp->scope&(IFA_LINK|IFA_HOST) || strict))) {
> + rcu_read_unlock_bh();
> + return 1;
> }
> }
> - rcu_read_unlock_bh();
>
> - return ifp != NULL;
> + rcu_read_unlock_bh();
> + return 0;
> }
> EXPORT_SYMBOL(ipv6_chk_addr);
>
>
>
This looks good to me.
Can you send a intact patch to David with my Report-by or Review-by ?
--
Best Regards
-----
Shan Wei
next prev parent reply other threads:[~2010-05-18 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 12:23 [PATCH BUGFIX ] ipv6: fix the bug of address check Shan Wei
2010-05-17 17:31 ` Stephen Hemminger
2010-05-18 0:50 ` Shan Wei [this message]
2010-05-18 1:02 ` [PATCH net-next] " Stephen Hemminger
2010-05-18 5:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF1E45D.5000409@cn.fujitsu.com \
--to=shanwei@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox