From: Daniel Lezcano <daniel.lezcano@free•fr>
To: opurdila@ixiacom•com
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH] net-2.6 : V2 - fix dev_get_valid_name
Date: Fri, 21 May 2010 15:10:13 +0200 [thread overview]
Message-ID: <4BF68635.4070202@free.fr> (raw)
In-Reply-To: <1274299939-28132-1-git-send-email-daniel.lezcano@free.fr>
On 05/19/2010 10:12 PM, Daniel Lezcano wrote:
> the commit:
>
> commit d90310243fd750240755e217c5faa13e24f41536
> Author: Octavian Purdila<opurdila@ixiacom•com>
> Date: Wed Nov 18 02:36:59 2009 +0000
>
> net: device name allocation cleanups
>
> introduced a bug when there is a hash collision making impossible
> to rename a device with eth%d. This bug is very hard to reproduce
> and appears rarely.
>
> The problem is coming from we don't pass a temporary buffer to
> __dev_alloc_name but 'dev->name' which is modified by the function.
>
> A detailed explanation is here:
>
> http://marc.info/?l=linux-netdev&m=127417784011987&w=2
>
> Changelog:
> V2 : replaced strings comparison by pointers comparison
>
> Signed-off-by: Daniel Lezcano<daniel.lezcano@free•fr>
> ---
>
Octavian, are you ok with this patch ?
next prev parent reply other threads:[~2010-05-21 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 20:12 [PATCH] net-2.6 : V2 - fix dev_get_valid_name Daniel Lezcano
2010-05-21 13:10 ` Daniel Lezcano [this message]
2010-05-21 13:25 ` Octavian Purdila
2010-05-24 6:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF68635.4070202@free.fr \
--to=daniel.lezcano@free$(echo .)fr \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=opurdila@ixiacom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox