Subject: Re: null dereference in ethoc_probe()

From: Thomas Chou <[email-masked]>
Date: Mon, 24 May 2010 08:29:30 +0800

Dan Carpenter wrote:
> The patch 0baa080c75c: "ethoc: use system memory as buffer" introduced a
> potential null dereference.
> 
>   1060  free:
>   1061          if (priv->dma_alloc)
>                     ^^^^^^^^^^^^^^^
> 	priv can be null here.
> 
>   1062                  dma_free_coherent(NULL, priv->dma_alloc, priv->membase,
>   1063                          netdev->mem_start);
>   1064          free_netdev(netdev);
> 
> Also I think the error handling is not as complete as it should be.  It
> seems like we should call devm_iounmap() and release some of the other
> resources as well.
> 
> regards,
> dan carpenter
> 
> 
> 
Hi Dan,

Thank you for reporting this bug. I will submit patch to fix this mistake.

Best regards,
Thomas