From: Thomas Chou <thomas@wytron•com.tw>
To: nios2-dev@sopc•et.ntust.edu.tw
Cc: netdev@vger•kernel.org, thierry.reding@avionic-design•de,
linux-kernel@vger•kernel.org, Dan Carpenter <error27@gmail•com>
Subject: Re: [Nios2-dev] [PATCH] ethoc: fix null dereference in ethoc_probe
Date: Tue, 25 May 2010 14:51:36 +0800 [thread overview]
Message-ID: <4BFB7378.6070900@wytron.com.tw> (raw)
In-Reply-To: <4BFB6B4B.3020107@zhaw.ch>
Tobias Klauser wrote:
>> @@ -944,6 +946,7 @@ static int ethoc_probe(struct platform_device *pdev)
>> priv = netdev_priv(netdev);
>> priv->netdev = netdev;
>> priv->dma_alloc = 0;
>> + priv->io_region_size = mmio->end - mmio->start + 1;
>
> Better use the resource_size inline here.
Hi Tobias,
I just see your patch of resource_size from the git log. Sorry, I missed
this one. I will send update on this. Thank you.
Cheers,
Thomas
prev parent reply other threads:[~2010-05-25 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 15:55 null dereference in ethoc_probe() Dan Carpenter
2010-05-24 0:29 ` Thomas Chou
2010-05-24 2:44 ` [PATCH] ethoc: fix null dereference in ethoc_probe Thomas Chou
2010-05-24 6:11 ` David Miller
2010-05-25 6:16 ` [Nios2-dev] " Tobias Klauser
2010-05-25 6:51 ` Thomas Chou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFB7378.6070900@wytron.com.tw \
--to=thomas@wytron$(echo .)com.tw \
--cc=error27@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nios2-dev@sopc$(echo .)et.ntust.edu.tw \
--cc=thierry.reding@avionic-design$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox