From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
To: Matthias Fuchs <matthias.fuchs-iOnpLzIbIdM@public•gmane.org>
Cc: Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH v3] can: Add driver for esd CAN-USB/2 device
Date: Wed, 26 May 2010 12:15:09 +0200 [thread overview]
Message-ID: <4BFCF4AD.6030000@grandegger.com> (raw)
In-Reply-To: <201005261114.03214.matthias.fuchs-iOnpLzIbIdM@public.gmane.org>
Hi Matthias,
On 05/26/2010 11:14 AM, Matthias Fuchs wrote:
> This patch adds a driver for esd's USB high speed
> CAN interface. The driver supports devices with
> multiple CAN interfaces.
>
> Signed-off-by: Matthias Fuchs <matthias.fuchs-iOnpLzIbIdM@public•gmane.org>
> ---
> version 3:
> - remove bus-error reporting feature because
> it cannot be controlled by user on demand
> with current device's firmware
> - rebased against current net-next-2.6 tree
>
> version 2:
> - use bus-error reporting and counters
> - minor cleanup
> - rebased against current net-next-2.6 tree
> - initial post to linux-usb list for review
I get the following compiler warnings when compiling the kernel:
CC drivers/net/can/usb/esd_usb2.o
drivers/net/can/usb/esd_usb2.c: In function 'esd_usb2_write_bulk_callback':
drivers/net/can/usb/esd_usb2.c:466: error: implicit declaration of function 'usb_buffer_free'
drivers/net/can/usb/esd_usb2.c: In function 'esd_usb2_setup_rx_urbs':
drivers/net/can/usb/esd_usb2.c:562: error: implicit declaration of function 'usb_buffer_alloc'
drivers/net/can/usb/esd_usb2.c:563: warning: assignment makes pointer from integer without a cast
drivers/net/can/usb/esd_usb2.c: In function 'esd_usb2_start_xmit':
drivers/net/can/usb/esd_usb2.c:732: warning: assignment makes pointer from integer without a cast
make[4]: *** [drivers/net/can/usb/esd_usb2.o] Error 1
This is due to commit e26bcf37234c67624f62d9fc95f922b8dbda1363.
You need a similar fix like for ems_usb.c. Are you using a recent
version of the net-next-2.6 tree?
Wolfgang.
next prev parent reply other threads:[~2010-05-26 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 9:14 [PATCH v3] can: Add driver for esd CAN-USB/2 device Matthias Fuchs
[not found] ` <201005261114.03214.matthias.fuchs-iOnpLzIbIdM@public.gmane.org>
2010-05-26 10:15 ` Wolfgang Grandegger [this message]
[not found] ` <4BFCF4AD.6030000-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-05-26 12:38 ` Matthias Fuchs
2010-05-26 11:31 ` Viral Mehta
[not found] ` <70376CA23424B34D86F1C7DE6B9973430254343AD9-fVvhrSDAkVjuuPCCJ6VnObSn4PsL5ZDKvpI+GvaZM4lBDgjK7y7TUQ@public.gmane.org>
2010-05-28 15:25 ` Matthias Fuchs
2010-05-31 6:35 ` Viral Mehta
2010-05-26 13:47 ` Oliver Neukum
[not found] ` <201005261547.34596.oneukum-l3A5Bk7waGM@public.gmane.org>
2010-05-28 14:19 ` Matthias Fuchs
2010-05-28 15:26 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFCF4AD.6030000@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public$(echo .)gmane.org \
--cc=Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=matthias.fuchs-iOnpLzIbIdM@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox