From: Mike Christie <michaelc@cs•wisc.edu>
To: open-iscsi@googlegroups•com
Cc: Rakesh Ranjan <rakesh@chelsio•com>,
NETDEVML <netdev@vger•kernel.org>,
SCSIDEVML <linux-scsi@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>, Karen Xie <kxie@chelsio•com>,
David Miller <davem@davemloft•net>,
James Bottomley <James.Bottomley@hansenpartnership•com>,
Anish Bhatt <anish@chelsio•com>,
Rakesh Ranjan <rranjan@chelsio•com>
Subject: Re: [PATCH 3/3] cxgb4i_v3: iscsi and libcxgbi library for handling common part
Date: Thu, 27 May 2010 00:59:26 -0500 [thread overview]
Message-ID: <4BFE0A3E.9020804@cs.wisc.edu> (raw)
In-Reply-To: <1273944249-311-4-git-send-email-rakesh@chelsio.com>
On 05/15/2010 12:24 PM, Rakesh Ranjan wrote:
> From: Rakesh Ranjan<rranjan@chelsio•com>
>
>
> Signed-off-by: Rakesh Ranjan<rakesh@chelsio•com>
> ---
> drivers/scsi/cxgb4i/cxgb4i_iscsi.c | 617 ++++++++++++++++++++++++++++++++++++
> drivers/scsi/cxgb4i/libcxgbi.c | 589 ++++++++++++++++++++++++++++++++++
> drivers/scsi/cxgb4i/libcxgbi.h | 430 +++++++++++++++++++++++++
I think the patch had some whitespace/newline issues. When I did git-am
I got:
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
I think James can just fix up when he merges with git, but in the future
you might want to try a git-am on your patch before you send (git-am
--whitespace=fix will fix it up for you).
> +
> +int cxgbi_pdu_init(struct cxgbi_device *cdev)
> +{
> + if (cdev->skb_tx_headroom> (512 * MAX_SKB_FRAGS))
> + cdev->skb_extra_headroom = cdev->skb_tx_headroom;
> + cdev->pad_page = alloc_page(GFP_KERNEL);
> + if (cdev->pad_page)
> + return -ENOMEM;
> + memset(page_address(cdev->pad_page), 0, PAGE_SIZE);
> + return 0;
> +
> + /*
> + if (SKB_TX_HEADROOM> (512 * MAX_SKB_FRAGS))
> + skb_extra_headroom = SKB_TX_HEADROOM;
> + pad_page = alloc_page(GFP_KERNEL);
> + if (!pad_page)
> + return -ENOMEM;
> + memset(page_address(pad_page), 0, PAGE_SIZE);
> + return 0;*/
Clean this up.
> +
> +void cxgbi_release_itt(struct iscsi_task *task, itt_t hdr_itt)
> +{
> + struct scsi_cmnd *sc = task->sc;
> + struct iscsi_tcp_conn *tcp_conn = task->conn->dd_data;
> + struct cxgbi_conn *cconn = tcp_conn->dd_data;
> + struct cxgbi_device *cdev = cconn->chba->cdev;
> + struct cxgbi_tag_format *tformat =&cdev->tag_format;
> + u32 tag = ntohl((__force u32)hdr_itt);
> +
> + cxgbi_tag_debug("release tag 0x%x.\n", tag);
> +
> + if (sc&&
> + (scsi_bidi_cmnd(sc) ||
> + sc->sc_data_direction == DMA_FROM_DEVICE)&&
> + cxgbi_is_ddp_tag(tformat, tag))
The formatting is a little weird. I think you want each line to start in
the same column instead of each getting tabbed over.
> +
> +
> +int cxgbi_reserve_itt(struct iscsi_task *task, itt_t *hdr_itt)
> +{
> + struct scsi_cmnd *sc = task->sc;
> + struct iscsi_conn *conn = task->conn;
> + struct iscsi_session *sess = conn->session;
> + struct iscsi_tcp_conn *tcp_conn = conn->dd_data;
> + struct cxgbi_conn *cconn = tcp_conn->dd_data;
> + struct cxgbi_device *cdev = cconn->chba->cdev;
> + struct cxgbi_tag_format *tformat =&cdev->tag_format;
> + u32 sw_tag = (sess->age<< cconn->task_idx_bits) | task->itt;
> + u32 tag;
> + int err = -EINVAL;
> +
> + if (sc&&
> + (scsi_bidi_cmnd(sc) ||
> + sc->sc_data_direction == DMA_FROM_DEVICE)&&
> + cxgbi_sw_tag_usable(tformat, sw_tag)) {
Same tabbing.
> + volatile unsigned int state;
I did not get why this needed to be volatile (I see it is like this in
cxgb3i and I did not see why in there too).
> +
> +static inline void cxgbi_sock_hold(struct cxgbi_sock *csk)
> +{
> + atomic_inc(&csk->refcnt);
We want people to use krefs instead of their own refcounting now.
> +
> +static inline void *cplhdr(struct sk_buff *skb)
> +{
> + return skb->data;
> +}
Seems kinda useless.
next prev parent reply other threads:[~2010-05-27 5:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 17:24 cxgb4i_v3.1 submission Rakesh Ranjan
[not found] ` <1273944249-311-1-git-send-email-rakesh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2010-05-15 17:24 ` [PATCH 1/3] cxgb4i_v3: add build support Rakesh Ranjan
[not found] ` <1273944249-311-2-git-send-email-rakesh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2010-05-15 17:24 ` [PATCH 2/3] cxgb4i_v3: main driver files Rakesh Ranjan
[not found] ` <1273944249-311-3-git-send-email-rakesh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2010-05-15 17:24 ` [PATCH 3/3] cxgb4i_v3: iscsi and libcxgbi library for handling common part Rakesh Ranjan
2010-05-27 5:59 ` Mike Christie [this message]
[not found] ` <4BFE0A3E.9020804-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2010-05-27 6:05 ` Rakesh Ranjan
2010-05-27 7:38 ` [PATCH 2/3] cxgb4i_v3: main driver files Mike Christie
2010-05-27 7:40 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2010-05-15 17:15 cxgb4i_v3 submission Rakesh Ranjan
2010-05-15 17:15 ` [PATCH 1/3] cxgb4i_v3: add build support Rakesh Ranjan
2010-05-15 17:15 ` [PATCH 2/3] cxgb4i_v3: main driver files Rakesh Ranjan
[not found] ` <1273943752-32486-3-git-send-email-rakesh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2010-05-15 17:15 ` [PATCH 3/3] cxgb4i_v3: iscsi and libcxgbi library for handling common part Rakesh Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFE0A3E.9020804@cs.wisc.edu \
--to=michaelc@cs$(echo .)wisc.edu \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=anish@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kxie@chelsio$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=open-iscsi@googlegroups$(echo .)com \
--cc=rakesh@chelsio$(echo .)com \
--cc=rranjan@chelsio$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox