Subject: Re: [Patch]r8169: remove unnecessary cast of readl()'s return value

From: Jeff Garzik <[email-masked]>
Date: Sun, 30 May 2010 13:36:12 -0400

On 05/30/2010 08:26 AM, Junchang Wang wrote:
> readl() returns a 32-bit integer on all platforms.
> There is no need to cast its return value.
>
> Signed-off-by: Junchang Wang<[email-masked]>
> ---
>   drivers/net/r8169.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 217e709..ca93cdf 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -88,7 +88,7 @@ static const int multicast_filter_limit = 32;
>   #define RTL_W32(reg, val32)	writel ((val32), ioaddr + (reg))
>   #define RTL_R8(reg)		readb (ioaddr + (reg))
>   #define RTL_R16(reg)		readw (ioaddr + (reg))
> -#define RTL_R32(reg)		((unsigned long) readl (ioaddr + (reg)))
> +#define RTL_R32(reg)		readl (ioaddr + (reg))

Ditto last email:  have you verified this matches all arch's definition 
of readl()?

	Jeff