From: KOVACS Krisztian <hidden@sch•bme.hu>
To: Patrick McHardy <kaber@trash•net>
Cc: David Miller <davem@davemloft•net>,
fw@strlen•de, jpirko@redhat•com, netdev@vger•kernel.org,
Balazs Scheidler <bazsi@balabit•hu>
Subject: Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed
Date: Fri, 25 Jun 2010 09:56:57 +0200 [thread overview]
Message-ID: <4C246149.3090603@sch.bme.hu> (raw)
In-Reply-To: <4C2379D9.2080608@trash.net>
Hi,
On 06/24/2010 05:29 PM, Patrick McHardy wrote:
> David Miller wrote:
>> From: Florian Westphal <fw@strlen•de>
>> Date: Wed, 23 Jun 2010 20:46:11 +0200
>>
>>> tproxy assigns skb->destructor, what prevents module unload while
>>> such skbs may
>>> still be around?
>>
>> The only reference to nf_tproxy_core.ko is for the symbol,
>> "nf_tproxy_assign_sock".
>> xt_TPROXY.c, which references this symbol, thus creates a symbol
>> dependency on this
>> module, so xt_TPROXY.o needs to unload before nf_tproxy_core.ko can
>> unload, and
>> xt_TPROXY.o has it's own manner for handling module references properly.
>
> I don't see anything waiting for skbs in flight using the tproxy
> destructor in either xt_TPROXY or nf_tproxy_core though, so I think
> Florian is correct.
Yes, I think Florian and Patrick's right. Right now there's nothing
preventing xt_TPROXY and nf_tproxy_core from being removed while there
are skbs in flight with the tproxy destructor set.
--
KOVACS Krisztian
next prev parent reply other threads:[~2010-06-25 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 18:35 [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed Jiri Pirko
2010-06-23 18:46 ` Florian Westphal
2010-06-23 18:55 ` David Miller
2010-06-24 15:29 ` Patrick McHardy
2010-06-25 7:56 ` KOVACS Krisztian [this message]
2010-06-29 6:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C246149.3090603@sch.bme.hu \
--to=hidden@sch$(echo .)bme.hu \
--cc=bazsi@balabit$(echo .)hu \
--cc=davem@davemloft$(echo .)net \
--cc=fw@strlen$(echo .)de \
--cc=jpirko@redhat$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox