public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jeremy Fitzhardinge <jeremy@goop•org>
To: Johann Baudy <johann.baudy@gnu-log•net>
Cc: NetDev <netdev@vger•kernel.org>,
	Ian Campbell <Ian.Campbell@citrix•com>,
	David Miller <davem@davemloft•net>
Subject: Why is destructor_arg in shinfo?
Date: Tue, 29 Jun 2010 16:09:13 +0200	[thread overview]
Message-ID: <4C29FE89.8090901@goop.org> (raw)

Hi,

I'm wondering why "net: TX_RING and packet mmap" (69e3c75) ended up
putting the skb destructor's arg in the skb's shinfo.  It seems like an
odd mismatch, since the skb and the shinfo have different lifetimes. 
And in principle you might have two skbs with different destructors
sharing a shinfo, and therefore conflict over the use of destructor_arg.

What's the rationale?

Would it make sense to have a shinfo destructor as well?

Thanks,
    J

                 reply	other threads:[~2010-06-29 14:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C29FE89.8090901@goop.org \
    --to=jeremy@goop$(echo .)org \
    --cc=Ian.Campbell@citrix$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=johann.baudy@gnu-log$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox