Subject: Re: [PATCH -next] myri10ge: clear NETIF_F_LRO bit directly

From: Andrew Gallatin <[email-masked]>
Date: Tue, 29 Jun 2010 11:44:14 -0400

Stanislaw Gruszka wrote:
> Do not use ethtool_op_set_flags() to clear one bit in ->features.
> Inform user about disabling LRO.

Thanks.. That simplifies things nicely.  But was
direct manipulation of netdev->features ever discouraged,
or has my use of ethtool_op_{get,set}_flags() to manipulate
the features always been complete overkill?

> Signed-off-by: Stanislaw Gruszka <[email-masked]>

Acked-by: Andrew J. Gallatin <[email-masked]>

Thanks,

Drew