From: "H. Peter Anvin" <hpa@zytor•com>
To: David Miller <davem@davemloft•net>
Cc: jeffrey.t.kirsher@intel•com, netdev@vger•kernel.org,
gospo@redhat•com, bphilips@novell•com, tglx@linutronix•de,
mingo@redhat•com, x86@kernel•org, alexander.h.duyck@intel•com
Subject: Re: [net-next-2.6 PATCH v2] x86: Align skb w/ start of cacheline on newer core 2/Xeon Arch
Date: Wed, 30 Jun 2010 14:32:33 -0700 [thread overview]
Message-ID: <4C2BB7F1.6050009@zytor.com> (raw)
In-Reply-To: <20100630.142832.51275605.davem@davemloft.net>
On 06/30/2010 02:28 PM, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
> Date: Tue, 29 Jun 2010 21:38:00 -0700
>
>> From: Alexander Duyck <alexander.h.duyck@intel•com>
>>
>> x86 architectures can handle unaligned accesses in hardware, and it has
>> been shown that unaligned DMA accesses can be expensive on Nehalem
>> architectures. As such we should overwrite NET_IP_ALIGN to resolve
>> this issue.
>>
>> Cc: Thomas Gleixner <tglx@linutronix•de>
>> Cc: Ingo Molnar <mingo@redhat•com>
>> Cc: "H. Peter Anvin" <hpa@zytor•com>
>> Cc: x86@kernel•org
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel•com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
>
> Can I get an x86'er ACK on this? I can merge it in via net-next-2.6
> which is probably most convenient for people who want to see the
> networking performance effects of this change.
Acked-by: H. Peter Anvin <hpa@zytor•com>
-hpa
next prev parent reply other threads:[~2010-06-30 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 4:38 [net-next-2.6 PATCH v2] x86: Align skb w/ start of cacheline on newer core 2/Xeon Arch Jeff Kirsher
2010-06-30 21:28 ` David Miller
2010-06-30 21:32 ` H. Peter Anvin [this message]
2010-06-30 21:34 ` David Miller
2010-07-01 11:28 ` Andi Kleen
2010-07-01 20:37 ` Alexander Duyck
2010-07-01 20:41 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2BB7F1.6050009@zytor.com \
--to=hpa@zytor$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=bphilips@novell$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox