From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
To: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public•gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH] CAN: Add Flexcan CAN controller driver
Date: Thu, 15 Jul 2010 11:37:57 +0200 [thread overview]
Message-ID: <4C3ED6F5.7040606@grandegger.com> (raw)
In-Reply-To: <1279144811-12251-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Hi Marc,
On 07/15/2010 12:00 AM, Marc Kleine-Budde wrote:
> From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public•gmane.org>
>
> This core is found on some Freescale SoCs and also some Coldfire
> SoCs. Support for Coldfire is missing though at the moment as
> they have an older revision of the core which does not have RX FIFO
> support.
>
> Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public•gmane.org>
> Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public•gmane.org>
> ---
>
> Changes to prev version:
> * The is now GPLv2 (only) as no one complained.
>
> The patch applies to current net-next-2.6/master.
> If there aren't any objections please consider applying this patch.
> Wolfgang, can I an Acked-by?
I already had a look to the previous version and I realized that
accessing reg_esr is racy. I will dig out my notes and come up with a
full review later today or tomorrow.
Thanks,
Wolfgang.
next prev parent reply other threads:[~2010-07-15 9:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 22:00 [PATCH] CAN: Add Flexcan CAN controller driver Marc Kleine-Budde
[not found] ` <1279144811-12251-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-07-15 9:37 ` Wolfgang Grandegger [this message]
[not found] ` <4C3ED6F5.7040606-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-07-15 10:06 ` Marc Kleine-Budde
[not found] ` <4C3EDDB1.5040109-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-07-15 10:21 ` Wolfgang Grandegger
2010-07-15 18:38 ` Wolfgang Grandegger
[not found] ` <4C3F55A9.8030307-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-07-16 13:21 ` Marc Kleine-Budde
[not found] ` <4C405CEC.3000701-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-07-21 20:42 ` Marc Kleine-Budde
[not found] ` <4C475BA6.3030505-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-07-22 9:25 ` Wolfgang Grandegger
[not found] ` <4C480E7E.70607-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-07-22 9:33 ` Marc Kleine-Budde
[not found] ` <4C481064.8090809-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-07-22 9:44 ` Wolfgang Grandegger
-- strict thread matches above, loose matches on Subject: below --
2010-07-22 16:40 Marc Kleine-Budde
2010-07-22 19:29 ` David Miller
2010-07-25 11:24 ` Oliver Hartkopp
2010-07-25 12:01 ` Marc Kleine-Budde
2010-06-17 14:21 Marc Kleine-Budde
[not found] ` <1276784480-32340-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-06-17 19:12 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3ED6F5.7040606@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public$(echo .)gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox