Subject: Re: [PATCH v2 0/3] cxgbi iscsi driver

From: Mike Christie <[email-masked]>
Date: Fri, 13 Aug 2010 11:32:06 -0500

On 08/13/2010 10:19 AM, [email-masked] wrote:
> [PATCH v2 0/3] cxgbi iscsi driver
>
> From: Karen Xie<[email-masked]>
>
> Re-submission, missed netdev list last time.
>
> This patchset includes:
>
> 1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
> 2. added cxgb4i iscsi initiator v5.
> 3. changed cxgb3i to use libcxgbi.
>
> The version 2 includes the following changes:
> - Made dbg_level static to avoid compiling errors when both cxgb3i and cxgb4i
>    are built into the kernel.
> - Deleted cxgbi_fill_iscsi_transport() and cxgbi_fill_scsi_host_template().
>    The iscsi_transport and scsi_host_template are initialized in the drivers
>    instead of being filled in by the library at runtime..
> - Only register with iscsi class transport once per driver type.
>

iSCSI and SCSI parts look ok now. The network code should be reviewed by 
the netdev people, because I am not qualified to review that. Thanks for 
your work Karen.

Reviewed-by: Mike Christie <[email-masked]>