From: Stephen Buck <stephen.buck@exinda•com>
To: David Miller <davem@davemloft•net>
Cc: "eric.dumazet@gmail•com" <eric.dumazet@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"netfilter-devel@vger•kernel.org"
<netfilter-devel@vger•kernel.org>,
"kaber@trash•net" <kaber@trash•net>,
"hidden@sch•bme.hu" <hidden@sch•bme.hu>
Subject: Re: tproxy related crash in inet_hashtables
Date: Mon, 16 Aug 2010 18:26:58 +1000 [thread overview]
Message-ID: <4C68F652.7070900@exinda.com> (raw)
In-Reply-To: <20100814.221611.15248639.davem@davemloft.net>
On 15/08/10 15:16, David Miller wrote:
> From: Stephen Buck<stephen.buck@exinda•com>
> Date: Sat, 14 Aug 2010 14:35:21 +1000
>
>
>> + }
>> + if (!node)
>> + tb = inet_bind_bucket_create(table->bind_bucket_cachep,
>> + sock_net(sk), head, port);
>> + }
>> sk_add_bind_node(child,&tb->owners);
>>
> inet_bind_bucket_create() can fail due to memory allocation failure,
> you're therefore going to have to find a way to handle that.
>
> And in doing so you're going to find out that there is no easy
> way out of this code path in such an error, this code was
> absolutely not designed to be able to handle cases like this.
>
You're right. I didn't cover the failure case. And no, it doesn't look easy.
I'll have another look at the problem when I get a chance.
Thanks for pointing it out.
prev parent reply other threads:[~2010-08-16 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 8:15 tproxy related crash in inet_hashtables Stephen Buck
2010-08-13 10:54 ` Eric Dumazet
2010-08-13 13:05 ` Stephen Buck
2010-08-13 13:55 ` Eric Dumazet
2010-08-14 4:35 ` Stephen Buck
2010-08-15 5:16 ` David Miller
2010-08-16 8:26 ` Stephen Buck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C68F652.7070900@exinda.com \
--to=stephen.buck@exinda$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=hidden@sch$(echo .)bme.hu \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox