Subject: Re: [PATCH net-next 11/14] tipc: Eliminate useless linked list initialization

From: Paul Gortmaker <[email-masked]>
Date: Wed, 18 Aug 2010 09:28:27 -0400

On 10-08-17 08:29 PM, David Miller wrote:
> From: Paul Gortmaker<[email-masked]>
> Date: Tue, 17 Aug 2010 17:00:13 -0400
> 
>> From: Allan Stephens<[email-masked]>
>>
>> Eliminate the initialization of the port_list field of a newly created
>> TIPC port, since the port is immediately added to TIPC's global list
>> of ports (which alters the port_list field).
>>
>> Signed-off-by: Allan Stephens<[email-masked]>
>> Signed-off-by: Paul Gortmaker<[email-masked]>
> 
> This is not correct.
> 
> INIT_LIST_HEAD() is mandatory for all new objects, since it may
> initialize debugging knobs and whatnot inside of the list_head object
> when certain debugging options are enabled.
> 
> Therefore it may never be elided.

Thanks, I should have come to the same conclusion when I was looking
at that one.

P.