Subject: Re: [PATCH v5 0/3] cxgbi iscsi driver

From: Mike Christie <[email-masked]>
Date: Thu, 19 Aug 2010 17:43:16 -0500

On 08/16/2010 10:55 PM, [email-masked] wrote:
> [PATCH v5 0/3] cxgbi iscsi driver
>
> From: Karen Xie<[email-masked]>
>
> This patchset includes:
>
> 1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
> 2. added cxgb4i iscsi initiator v5.
> 3. changed cxgb3i to use libcxgbi.
>
> Version 5 changes:
> - got rid of log_error/warn/info and used pr_<level>  instead.
> - "%zu" for printing out sizeof().
> - made sure all printk messages have trailing "."
>

iSCSI and scsi parts look ok to me.

Reviewed-by: Mike Christie <[email-masked]>

I looked at the network code and it looks similar to what is in the 
cxgb3i driver upstream, so I think it should be ok, but I am not 100% 
sure so probably needs a netdev ack.

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/[email-masked]
To unsubscribe from this group, send email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email-masked]
For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.