From: Michael Williamson <michael.williamson@criticallink•com>
To: cyril@ti•com
Cc: Kevin Hilman <khilman@deeprootsystems•com>,
"tony@atomide•com" <tony@atomide•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davinci-linux-open-source@linux•davincidsp.com"
<davinci-linux-open-source@linux•davincidsp.com>,
"linux-omap@vger•kernel.org" <linux-omap@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>
Subject: Re: [PATCH v3 00/10] split out emac cpdma and mdio for reuse
Date: Wed, 08 Sep 2010 20:47:38 -0400 [thread overview]
Message-ID: <4C882EAA.9030903@criticallink.com> (raw)
In-Reply-To: <4C880733.5010909@ti.com>
Hi Cyril,
On 09/08/2010 05:59 PM, Cyril Chemparathy wrote:
> Hi Mike,
>
> [...]
>> So I just pulled this to test it out on a da850 based board
>> (mitydspl138), and I'm having some problems. I'm hoping it's just
>> operator error.
>
> Probably not, considering that this series had not been tested on da8xx
> platforms. Thanks for jumping in!
>
Jumped, pushed, you say tomato, ... ;^)
>> I have a TI TLK100PHP PHY at address 0x3. The boot log shows:
>>
>> [snip]
>> davinci_mdio davinci_mdio.0: davinci mdio revision 1.5
>> davinci_mdio davinci_mdio.0: detected phy mask fffffff7
>> davinci_mdio.0: probed
>> davinci_mdio davinci_mdio.0: phy[3]: device 0:03, driver unknown
>> [snip]
>
> So far so good. The MDIO code seems to have done its part and latched
> on to the correct phy. To answer your question from below, the "driver
> unknown" implies that the generic phy driver has been attached to the
> detected phy.
>
>> and then in the init scripts, following udev population I get a
>> "Configuring network interfaces... "
>>
>> and the boot process just hangs.
>
> Not a peep from emac? Strange.
>
So I went in and set the debug_level to netif_msg_init() to -1 in the davinci_emac
driver. The only thing I get during the boot process is:
net eth0: DaVinci EMAC Probe found device (regs: 01e23000, irq: 33)
which is good (I also added some debug to make sure probe actually completes), but
I don't see *anything* else. I guess I would have expected to see something out of
the emac_dev_open. So I added some more debug in there, it's hanging in the
phy_connect() call. The phy_id it came up with was correct "0:03".
[snip]
>
> I spent some time today on testing this series on a da830 evm board
> (sorry, couldn't manage to scrounge up a da850 platform). In the
> process, I have had to put in some fixes, particularly for the
> phy-association piece. You can preview these commits on my repo's
> gitweb [1].
>
I did apply the requeue on early end-of-queue patch. No difference, which is not
surprising as it's dying in the phy_connect. I don't think I need the others,
as the correct phy_id is being located by the MDIO probe headed
into the phy_connect call (pointer is valid, string is OK, etc.). If I have time I
can continue to poke around, but I'm really not up on this chunk of code...
-Mike
next prev parent reply other threads:[~2010-09-09 0:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 20:25 [PATCH v3 00/10] split out emac cpdma and mdio for reuse Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 01/10] net: davinci_emac: separate out davinci mdio Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 02/10] davinci: add mdio platform devices Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 03/10] omap: " Cyril Chemparathy
2010-09-08 1:00 ` Tony Lindgren
2010-09-07 20:25 ` [PATCH v3 04/10] net: davinci_emac: switch to new mdio Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 05/10] davinci: cleanup unused davinci mdio arch code Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 06/10] omap: " Cyril Chemparathy
2010-09-08 1:00 ` Tony Lindgren
2010-09-07 20:25 ` [PATCH v3 07/10] net: davinci_emac: cleanup unused mdio emac code Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 08/10] net: davinci_emac: separate out cpdma code Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 09/10] net: davinci_emac: switch to new cpdma layer Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 10/10] net: davinci_emac: cleanup unused cpdma code Cyril Chemparathy
2010-09-08 1:18 ` [PATCH v3 00/10] split out emac cpdma and mdio for reuse Kevin Hilman
2010-09-08 2:22 ` Michael Williamson
2010-09-08 21:59 ` Cyril Chemparathy
2010-09-09 0:47 ` Michael Williamson [this message]
2010-09-09 18:43 ` Michael Williamson
2010-09-09 19:51 ` Cyril Chemparathy
2010-09-09 21:24 ` Cyril Chemparathy
2010-09-09 21:45 ` Michael Williamson
2010-09-09 21:25 ` Michael Williamson
2010-09-10 15:23 ` Caglar Akyuz
2010-09-11 8:54 ` Caglar Akyuz
2010-09-13 14:09 ` Cyril Chemparathy
2010-09-13 15:46 ` Cyril Chemparathy
2010-09-13 17:51 ` Caglar Akyuz
2010-09-10 22:59 ` Cyril Chemparathy
2010-09-11 13:14 ` Michael Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C882EAA.9030903@criticallink.com \
--to=michael.williamson@criticallink$(echo .)com \
--cc=cyril@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=davinci-linux-open-source@linux$(echo .)davincidsp.com \
--cc=khilman@deeprootsystems$(echo .)com \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tony@atomide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox