From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
To: Masayuki Ohtake <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public•gmane.org>
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
qi.wang-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
gregkh-l3A5Bk7waGM@public•gmane.org,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public•gmane.org>,
Tomoya MORINAGA
<morinaga526-ECg8zkTtlr0C6LszWs/t0g@public•gmane.org>,
meego-dev-WXzIur8shnEAvxtiuMwx3w@public•gmane.org,
arjan-VuQAYsv1563Yd54FQh9/CA@public•gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
Christian Pellegrin <chripell-VaTbYqLCNhc@public•gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public•gmane.org>
Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35
Date: Thu, 16 Sep 2010 11:10:56 +0200 [thread overview]
Message-ID: <4C91DF20.7040807@grandegger.com> (raw)
In-Reply-To: <002601cb557c$69292180$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
On 09/16/2010 10:51 AM, Masayuki Ohtake wrote:
> Hi Marc,
>
>> - Please remove rx-filter handling from the driver completely, simply
>> receive every can frame
>
> This rx-filter function is for Topcliff's CAN HW function.
> This function is important.
> Could you tell us the reason why should we remove filter function ?
We do not (yet) support the filtering capability of the CAN controller
hardware. Therefore please configure the hardware filter to accept *any*
CAN message like all other drivers do, e.g.:
http://lxr.linux.no/#linux+v2.6.35.4/drivers/net/can/sja1000/sja1000.c#L249
Wolfgang.
next prev parent reply other threads:[~2010-09-16 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C8E1773.9090000@dsn.okisemi.com>
[not found] ` <4C8E1773.9090000-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-09-13 15:14 ` [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35 Marc Kleine-Budde
2010-09-16 8:51 ` Masayuki Ohtake
[not found] ` <002601cb557c$69292180$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
2010-09-16 9:10 ` Wolfgang Grandegger [this message]
2010-09-16 23:55 ` Masayuki Ohtake
2010-09-13 18:47 ` Daniel Baluta
2010-09-15 7:36 ` Wolfgang Grandegger
2010-09-13 12:22 Masayuki Ohtak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C91DF20.7040807@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public$(echo .)gmane.org \
--cc=andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=arjan-VuQAYsv1563Yd54FQh9/CA@public$(echo .)gmane.org \
--cc=chripell-VaTbYqLCNhc@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=gregkh-l3A5Bk7waGM@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=masa-korg-ECg8zkTtlr0C6LszWs/t0g@public$(echo .)gmane.org \
--cc=meego-dev-WXzIur8shnEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public$(echo .)gmane.org \
--cc=morinaga526-ECg8zkTtlr0C6LszWs/t0g@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=qi.wang-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public$(echo .)gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
--cc=yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox